Commit 5dfb1d7
committed
fix(config_validate): add missing aliases/providerFallbacks to schema; fix deprecated-key bypass
Two real schema gaps found via dogfood (cargo test -p runtime):
1. aliases and providerFallbacks not in TOP_LEVEL_FIELDS
- Both are valid config keys parsed by config.rs
- Validator was rejecting them as unknown keys
- 2 tests failing: parses_user_defined_model_aliases,
parses_provider_fallbacks_chain
2. Deprecated keys were being flagged as unknown before the deprecated
check ran (unknown-key check runs first in validate_object_keys)
- Added early-exit for deprecated keys in unknown-key loop
- Keeps deprecated→warning behavior for permissionMode/enabledPlugins
which still appear in valid legacy configs
3. Config integration tests had assertions on format strings that never
matched the actual validator output (path:3: vs path: ... (line N))
- Updated assertions to check for path + line + field name as
independent substrings instead of a format that was never produced
426 tests passing, 0 failing.1 parent fcb5d0c commit 5dfb1d7
2 files changed
Lines changed: 41 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1931 | 1931 | | |
1932 | 1932 | | |
1933 | 1933 | | |
1934 | | - | |
1935 | | - | |
| 1934 | + | |
| 1935 | + | |
1936 | 1936 | | |
1937 | 1937 | | |
1938 | | - | |
| 1938 | + | |
| 1939 | + | |
| 1940 | + | |
| 1941 | + | |
| 1942 | + | |
1939 | 1943 | | |
1940 | 1944 | | |
1941 | 1945 | | |
| |||
1965 | 1969 | | |
1966 | 1970 | | |
1967 | 1971 | | |
1968 | | - | |
1969 | | - | |
| 1972 | + | |
| 1973 | + | |
1970 | 1974 | | |
1971 | 1975 | | |
1972 | | - | |
1973 | | - | |
| 1976 | + | |
| 1977 | + | |
1974 | 1978 | | |
1975 | 1979 | | |
1976 | | - | |
1977 | | - | |
| 1980 | + | |
| 1981 | + | |
| 1982 | + | |
| 1983 | + | |
| 1984 | + | |
| 1985 | + | |
| 1986 | + | |
1978 | 1987 | | |
1979 | 1988 | | |
1980 | 1989 | | |
| |||
2003 | 2012 | | |
2004 | 2013 | | |
2005 | 2014 | | |
2006 | | - | |
2007 | | - | |
| 2015 | + | |
| 2016 | + | |
2008 | 2017 | | |
2009 | 2018 | | |
2010 | | - | |
| 2019 | + | |
| 2020 | + | |
| 2021 | + | |
| 2022 | + | |
| 2023 | + | |
2011 | 2024 | | |
2012 | 2025 | | |
| 2026 | + | |
| 2027 | + | |
| 2028 | + | |
| 2029 | + | |
2013 | 2030 | | |
2014 | 2031 | | |
2015 | 2032 | | |
| |||
2033 | 2050 | | |
2034 | 2051 | | |
2035 | 2052 | | |
2036 | | - | |
| 2053 | + | |
2037 | 2054 | | |
2038 | 2055 | | |
2039 | 2056 | | |
2040 | | - | |
| 2057 | + | |
2041 | 2058 | | |
2042 | 2059 | | |
2043 | 2060 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
188 | 196 | | |
189 | 197 | | |
190 | 198 | | |
| |||
364 | 372 | | |
365 | 373 | | |
366 | 374 | | |
| 375 | + | |
| 376 | + | |
367 | 377 | | |
368 | 378 | | |
369 | 379 | | |
| |||
0 commit comments