Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling in Main.storyboard #75

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix spelling in Main.storyboard #75

merged 2 commits into from
Jan 9, 2025

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jan 1, 2025

@asabri97 @john-rocky FYI Ultralytics Actions found a typo here, I think "forcus" -> "focus"?
https://github.com/ultralytics/yolo-ios-app/actions/runs/12098109948/job/33734235835

Please check these directly in your repos in the future, thank you!

Run codespell \
./YOLO/Main.storyboard:297: forcus ==> focus, forces
./YOLO/ViewController.swift:43: forcus ==> focus, forces

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Fixed a typo in variable naming for improved code readability in the YOLO iOS app. 🛠️🐛

📊 Key Changes

  • Corrected a typo in an IBOutlet variable name from forcus to focus in Main.storyboard and ViewController.swift.

🎯 Purpose & Impact

  • Purpose: Ensure cleaner, more professional code by aligning variable names with proper spelling.
  • Impact: Enhances maintainability and understanding for developers working on or reviewing the code. No direct impact on end-users, but contributes to overall project quality. 🙌

@asabri97 @john-rocky FYI Ultralytics Actions found a typo here, I think "forcus" -> "focus". 
https://github.com/ultralytics/yolo-ios-app/actions/runs/12098109948/job/33734235835


Please check these directly in your repos in the future, thank you!
```
Run codespell \
./YOLO/Main.storyboard:297: forcus ==> focus, forces
./YOLO/ViewController.swift:43: forcus ==> focus, forces
```

Signed-off-by: Glenn Jocher <[email protected]>
@UltralyticsAssistant UltralyticsAssistant added the documentation Improvements or additions to documentation label Jan 1, 2025
Signed-off-by: Glenn Jocher <[email protected]>
@UltralyticsAssistant
Copy link
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/yolo-ios-app 🚀 PR! To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yolo-ios-app main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

We noticed that this PR fixes a spelling error in the storyboard file. To confirm everything behaves as expected, please ensure that all related changes in the corresponding files (e.g., ViewController.swift) are reflected, and functionality across the app remains unaffected by the outlet renaming. 🙌

For additional guidance, please refer to our Contributing Guide. Don’t hesitate to leave a comment if you have any questions. An Ultralytics engineer will review your contribution promptly and provide additional assistance if needed! ✨ Thank you for contributing to Ultralytics! 🚀

@asabri97 asabri97 merged commit 40d1c6b into main Jan 9, 2025
3 checks passed
@asabri97 asabri97 deleted the fix-spelling branch January 9, 2025 15:52
@UltralyticsAssistant
Copy link
Member

🎉 Your PR has been merged! Thank you so much, @glenn-jocher and @asabri97, for your sharp attention to detail and commitment to excellence. Fixing the forcus to focus typo may seem small, but as Leonardo da Vinci once said, "Details make perfection, and perfection is not a detail." Your contribution enhances the foundation of the YOLO iOS app, paving the way for a cleaner, more maintainable project for all. 🚀🙌 Keep up the amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants