Duplicate definition of brevity

[cokernel]

The functions

exploreuk-web-app/shim/application/libraries/ExploreUK/View.php

Lines 47 to 77 in f808eed

	public function brevity($message, $length = 0)
	{
	if ($length == 0) {
	$length = EUK_MAX_LABEL;
	}
	if (strlen($message) <= $length) {
	return $message;
	}
	$source_words = preg_split('/\b/', $message);
	$target_words = array();
	$current_length = 0;
	foreach ($source_words as $word) {
	if (($current_length == 0) || $current_length + strlen($word) <= $length) {
	$target_words[] = $word;
	$current_length += strlen($word);
	} else {
	break;
	}
	}
	$count = count($target_words);
	if ($count == 0) {
	$message = '…';
	} else {
	$terminal = $target_words[$count - 1];
	if (preg_match('/^\W+$/', $terminal)) {
	array_pop($target_words);
	}
	$message = implode('', $target_words) . '…';
	}
	return $message;
	}

exploreuk-web-app/shim/application/libraries/ExploreUK/definitions.php

Lines 151 to 181 in f808eed

	function brevity($message, $length = 0)
	{
	if ($length == 0) {
	$length = EUK_MAX_LABEL;
	}
	if (strlen($message) <= $length) {
	return $message;
	}
	$source_words = preg_split('/\b/', $message);
	$target_words = array();
	$current_length = 0;
	foreach ($source_words as $word) {
	if (($current_length == 0) || $current_length + strlen($word) <= $length) {
	$target_words[] = $word;
	$current_length += strlen($word);
	} else {
	break;
	}
	}
	$count = count($target_words);
	if ($count == 0) {
	$message = '…';
	} else {
	$terminal = $target_words[$count - 1];
	if (preg_match('/^\W+$/', $terminal)) {
	array_pop($target_words);
	}
	$message = implode('', $target_words) . '…';
	}
	return $message;
	}

have identical bodies. Is there a reason why they are defined separately?

[cokernel]

The method brevity on View is used in a few views, for example:

exploreuk-web-app/shim/application/libraries/ExploreUK/views/facets.php

Line 27 in c0d5fda

<li><a href="<?= $value['add_link'] ?>"><?= $this->brevity($value['value_label'], 40) ?> <span class="facet-count">(<?= $value['count'] ?>)</span></a></li>

It seems likely that these occurrences of $this->brevity can just be replaced with brevity, but this requires testing.