Skip to content

Commit 788705d

Browse files
authored
fix: autoConvertControllerClass to consider controller.ts file as well (not just .js) (#140)
Fixes #139
1 parent 0685a32 commit 788705d

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -803,7 +803,8 @@ In general, comments are preserved, but for each class property/method whose pos
803803

804804
- `namespacePrefix` (Default: '') Prefix to apply to namespace derived from directory.
805805
- `autoConvertAllExtendClasses` (Default false). Converts all classes by default, provided they extend from an imported class. Version 6 default behaviour.
806-
- `autoConvertControllerClass` (Default true). Converts the classes in a `.controller.js` file by default, if it extends from an imported class. Use `@nonui5` if there are multiple classes in a controller file which extend from an import.
806+
- `autoConvertControllerClass` (Default true). Converts the classes in a `.controller.js` (or .ts) file by default, if it extends from an imported class.
807+
Use `@nonui5` if there are multiple classes in a controller file which extend from an import.
807808
- `neverConvertClass` (Default: false) Never convert classes to SAPClass.extend() syntax.
808809
- `moveControllerPropsToOnInit` (Default: false) Moves class props in a controller to the onInit method instead of constructor.
809810
- `moveControllerConstructorToOnInit` (Default: false) Moves existing constructor code in a controller to the onInit method. Enabling will auto-enable `moveControllerPropsToOnInit`.

packages/plugin/src/classes/visitor.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,9 @@ function shouldConvertClass(file, node, opts, classInfo) {
229229
) {
230230
return true;
231231
}
232+
// Convert controller classes
232233
if (
233-
/.*[.]controller[.]js$/.test(file.opts.filename) &&
234+
/.*[.]controller[.](js|ts)$/.test(file.opts.filename) &&
234235
opts.autoConvertControllerClass !== false
235236
) {
236237
return true;

0 commit comments

Comments
 (0)