Add QC checks for ICE source files #1024
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Implements some QC checks on the source CICE6 restart files to fix possible issues known to cause run-time failures in the coupled model. A unit test is added for the QC test functionality.
TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
Describe any additional tests performed.
Baselines were run on Hera. The downscaled ocean warmstarts are B4B, as expected. The 1/2 deg and 1 deg ice files fail comparison. The only differences were seen in fields which are QC'd (category ice coverage, volume and snow volume and surface temperature).
The initial, unfixed IC restart file used during the investigation of the negative dvice issue was QC'd using the ocnice-prep utility. Using the
debug=.true.
setting for the ocnice-prep, the QC'd fields were dumped to a netCDF file. The four fields QC'd (aicen, vicen, vsnon, Tsfcn) were identical to those generated via ncap2 commands previously identified as fixing the negative dvice issue. For completeness, the script using ncap2 isISSUE: