Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove unnecessary build on push #234

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

p5
Copy link
Member

@p5 p5 commented Feb 2, 2025

We're unnecessarily using GitHub Actions builders to build the images after they have been built twice already (when committing to PRs and inside the merge group).

This change allows us to build and push inside the merge queue, and removes the unnecessary build on pushes to the main branch.

@p5 p5 requested a review from tulilirockz as a code owner February 2, 2025 02:11
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 2, 2025
@castrojo castrojo enabled auto-merge February 2, 2025 02:11
Copy link
Member

@castrojo castrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone check og bluefin while we're at it? 🗡️

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 2, 2025
@p5
Copy link
Member Author

p5 commented Feb 2, 2025

Can someone check og bluefin while we're at it? 🗡️

I copied ublue-os/bluefin's settings for here. We're doing things right over there

@castrojo castrojo added this pull request to the merge queue Feb 2, 2025
Merged via the queue into main with commit 1064deb Feb 2, 2025
17 checks passed
@castrojo castrojo deleted the remove-push-workflow-trigger branch February 2, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants