Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: some random output when entering distrobox while using fish shell #201

Open
RealVishy opened this issue Feb 8, 2025 · 2 comments
Open
Labels
bug Something isn't working

Comments

@RealVishy
Copy link
Collaborator

Describe the bug

I'm getting some random output about starfish when i enter a distrobox while having my shell set to fish.

Image

Probably an issue with the fish container detection logic that was merged way back, might have to look into it again.

What did you expect to happen?

no stuff about starfish when you make a new distrobox

Output of bootc status

❯  sudo bootc status
[sudo] password for vishwas: 
  Staged image: ghcr.io/ublue-os/aurora-dx:stable-daily
        Digest: sha256:8f9e0a7ccb2b4d9f812e55d2c1d69a4843cf7f7be3f33cb8405d56b338b08520
       Version: 41.20250208.2 (2025-02-08 07:22:39 UTC)

● Booted image: ghcr.io/ublue-os/aurora-dx:stable-daily
        Digest: sha256:781d39a91bea15441f4ce7bd85359d65bd458316e03f951fad3d567631feb966
       Version: 41.20250205.8 (2025-02-05 18:16:11 UTC)

  Rollback image: ghcr.io/ublue-os/aurora-dx:stable-daily
          Digest: sha256:7eab0bf90ce4c4e8c5909f85472c7699539137f78149a11ba79fc7638079e48c
         Version: 41.20250205.7 (2025-02-05 16:11:54 UTC)

Output of groups

Extra information or context

No response

@dosubot dosubot bot added the bug Something isn't working label Feb 8, 2025
@goek-han
Copy link
Contributor

I think everything that is not installed in the container but referenced in your host's fish config fails. I don't know how to prevent this. On my machine I use direnv from brew and everytime I enter a distrobox I get:

Container Setup Complete!
fish: Unknown command: /home/linuxbrew/.linuxbrew/bin/direnv
~/.config/fish/config.fish (line 5):
/home/linuxbrew/.linuxbrew/bin/direnv hook fish | source
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
from sourcing file ~/.config/fish/config.fish
        called during startup
fish: Unknown command: brew
~/.config/fish/config.fish (line 1):
brew --prefix
^~~^
in command substitution
        called on line 45 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
        called during startup
~/.config/fish/config.fish (line 45): Unknown command
if test -d (brew --prefix)"/share/fish/completions"
           ^~~~~~~~~~~~~~^
from sourcing file ~/.config/fish/config.fish
        called during startup
fish: Unknown command: brew
~/.config/fish/config.fish (line 1):
brew --prefix
^~~^
in command substitution
        called on line 49 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
        called during startup
~/.config/fish/config.fish (line 49): Unknown command
if test -d (brew --prefix)"/share/fish/vendor_completions.d"
           ^~~~~~~~~~~~~~^
from sourcing file ~/.config/fish/config.fish
        called during startup

@RealVishy
Copy link
Collaborator Author

I think the only way to avoid this is to use a custom home dir for your distrobox.

I did that in this distrobox here and it uses the distrobox's config.fish instead of trying to source everything from your user's config.fish.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants