Skip to content

Commit 8c38015

Browse files
author
Akshay Shah
committed
Disable relaying in flaky test
As mentioned in the pre-existing comment, enabling relaying makes this test flaky. We can re-enable once #390 is resolved.
1 parent eca8a4c commit 8c38015

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

connection_test.go

+5-4
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,13 @@ import (
3131
"time"
3232

3333
. "github.com/uber/tchannel-go"
34-
35-
"github.com/stretchr/testify/assert"
36-
"github.com/stretchr/testify/require"
3734
"github.com/uber/tchannel-go/raw"
35+
"github.com/uber/tchannel-go/relay"
3836
"github.com/uber/tchannel-go/testutils"
3937
"github.com/uber/tchannel-go/testutils/testreader"
38+
39+
"github.com/stretchr/testify/assert"
40+
"github.com/stretchr/testify/require"
4041
"golang.org/x/net/context"
4142
)
4243

@@ -548,7 +549,7 @@ func TestWriteAfterConnectionError(t *testing.T) {
548549
// Closing network connections can lead to warnings in many places.
549550
// TODO: Relay is disabled due to https://github.com/uber/tchannel-go/issues/390
550551
// Enabling relay causes the test to be flaky.
551-
opts := testutils.NewOpts().DisableLogVerification()
552+
opts := testutils.NewOpts().DisableLogVerification().NoRelay()
552553
testutils.WithTestServer(t, opts, func(ts *testutils.TestServer) {
553554
testutils.RegisterEcho(ts.Server(), nil)
554555
server := ts.Server()

0 commit comments

Comments
 (0)