Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing for many to one propensity matching without replacement #785

Closed
spohngellert-o opened this issue Jul 19, 2024 · 1 comment
Closed

Allowing for many to one propensity matching without replacement #785

spohngellert-o opened this issue Jul 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@spohngellert-o
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Currently, the ratio field of NearestNeighborMatch is only used if replace=True. I believe that it would be helpful to allow many to one matching without replacement.

Describe the solution you'd like

Alter the match method to allow for many to one matching.

Describe alternatives you've considered

None

Additional context

No additional context, but happy to hear opinions if there's a reason not to implement 😄
@spohngellert-o spohngellert-o added the enhancement New feature or request label Jul 19, 2024
@jeongyoonlee
Copy link
Collaborator

This was fixed in #786. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeongyoonlee @spohngellert-o