Feat: use separate config for s3 bucket configuration for result download from s3

Author: jan.kaifer

go/config.go

@@ -213,6 +213,23 @@ func (c *Config) GetS3ResultPrefix() string {
 	return GetFromEnvVal(s3ResultPrefixEnvKey)
 }
 
+// SetS3OutputBucket is setter for S3 output bucket
+func (c *Config) SetS3OutputBucket(o string) error {
+	if len(o) == 0 {
+		return ErrConfigS3OutputBucket
+	}
+	c.values.Set("s3_output_bucket", o)
+	return nil
+}
+
+// GetS3OutputBucket is getter of s3 output bucket
+func (c *Config) GetS3OutputBucket() string {
+	if val := c.values.Get("s3_output_bucket"); val != "" {
+		return val
+	}
+	return ""
+}
+
 // SetUser is a setter of User.
 func (c *Config) SetUser(o string) {
 	c.dsn.User = url.UserPassword(o, "")

go/errors.go

@@ -32,6 +32,7 @@ var (
 	ErrConfigOutputLocation         = errors.New("output location must starts with s3")
 	ErrConfigRegion                 = errors.New("region is required")
 	ErrConfigS3ResultPrefix         = errors.New("S3 result prefix is required")
+	ErrConfigS3OutputBucket         = errors.New("S3 output bucket is required")
 	ErrConfigWGPointer              = errors.New("workgroup pointer is nil")
 	ErrConfigAccessIDRequired       = errors.New("AWS access ID is required")
 	ErrConfigAccessKeyRequired      = errors.New("AWS access Key is required")

go/rows.go

@@ -109,7 +109,7 @@ func (r *Rows) DownloadResultFromS3() (*csv.Reader, error) {
 
 	client := s3.NewFromConfig(cfg)
 
-	bucket := r.config.GetOutputBucket()
+	bucket := r.config.GetS3OutputBucket()
 	path := fmt.Sprintf("%s/%s.csv", r.config.GetS3ResultPrefix(), r.queryID)
 
 	output, err := client.GetObject(context.TODO(), &s3.GetObjectInput{