-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saved Passwords Disappear After App Close/Reopen #1735
Comments
Can confirm that loss of saved passwords is a potential issue for 132. |
as mentioned in https://source.chromium.org/chromium/chromium/src/+/main:components/password_manager/core/browser/buildflags.gni google has decided to remove the internal chromium store of passwords in android. |
This looks related?: 6157381: [UPM] Check USE_LOGIN_DATABASE_AS_BACKEND before removing the db with I haven't had a chance to try yet but plan to later today. |
thank you, I will check.
already pointed out but they don't care. |
To stop saved passwords from disappearing? Yes, I think so. I just got a chance to try, and it looks like something worked, so now I need to narrow that down. I think it was the related patch I linked + the build arg. Edit: But then I guess this would still be storing them unencrypted, you're saying? It is in the app's internal data, so not the worst, but...? I haven't dug into resolving that part yet. |
M132 changed the way the built-in login database is handled and included an unfortunate oversight that caused logins to be cleared, even with use_login_database_as_backend=true (already set via Restore-chrome-password-store.patch). This has been fixed upstream. That fix is included here manually for now. Issue: calyxos#2935 Issue: uazo#1735 Change-Id: I52b5d454a06659593471cbdbddcb11fd259fec78
I'll add to this, that on modern Android devices, user data is always encrypted, and due to application sandboxing - other apps wouldn't be able to access cromite's internal data. So while it's still not ideal in some ways, it's definitely a lot better than doing the same on other platforms. |
M132 changed the way the built-in login database is handled and included an unfortunate oversight that caused logins to be cleared, even with use_login_database_as_backend=true (already set via Restore-chrome-password-store.patch). This has been fixed upstream. That fix is included here manually for now. Issue: calyxos#2935 Issue: uazo/cromite#1735 Change-Id: I52b5d454a06659593471cbdbddcb11fd259fec78
sure, but:
therefore I consider it a mitigation |
I was finally able to check: the behaviour is due to the @t-m-w thanks for pointing that out to me. |
Preliminary checklist
Can the bug be reproduced with corresponding Chromium version?
Yes
Are you sure?
Yes
Cromite version
version 132.0.6834.83
Device architecture
arm
Platform version
Android 13
Android Device model
Realme Gt Master edition
Is the device rooted?
No
Changed flags
No flags changed
Is this bug happening ONLY in an incognito tab?
No
Is this bug caused by the adblocker?
No
Is this bug a crash?
No
Describe the bug
Saved Passwords Disappear After App Close/Reopen
(Old saved passwords also missing)
Steps to reproduce the bug
Save new password/close the app and try to open the app. There won't be any password saved on password manager
Expected behavior
All saved passwords would be missing
Screenshots
Details
The text was updated successfully, but these errors were encountered: