Skip to content

Commit ecab82f

Browse files
committed
chore!: remove public visibility some PackageManifest functions
BREAKING CHANGE: remove public visbility on the following `PackageManifest` functions: - `get_dependency_versions` - `dependencies_iter` - `internal_dependencies_iter` - `transitive_interna_dependency_package_names_exclusive` - `npm_pack_file_basename` - `unscoped_package_name` These functions are intended for internal use only.
1 parent a2220d7 commit ecab82f

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

crates/typescript_tools/src/package_manifest.rs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ impl AsRef<PackageManifest> for PackageManifest {
7373
impl PackageManifest {
7474
// REFACTOR: for nearness
7575
// Get the dependency
76-
pub fn get_dependency_version<S>(&self, dependency: S) -> Option<String>
76+
pub(crate) fn get_dependency_version<S>(&self, dependency: S) -> Option<String>
7777
where
7878
S: AsRef<str>,
7979
{
@@ -96,7 +96,9 @@ impl PackageManifest {
9696
.next()
9797
}
9898

99-
pub fn dependencies_iter(&self) -> impl Iterator<Item = (PackageName, &serde_json::Value)> {
99+
pub(crate) fn dependencies_iter(
100+
&self,
101+
) -> impl Iterator<Item = (PackageName, &serde_json::Value)> {
100102
DependencyGroup::VALUES
101103
.iter()
102104
.filter_map(|dependency_group| {
@@ -111,7 +113,7 @@ impl PackageManifest {
111113
})
112114
}
113115

114-
pub fn internal_dependencies_iter<'a>(
116+
pub(crate) fn internal_dependencies_iter<'a>(
115117
&'a self,
116118
package_manifests_by_package_name: &'a HashMap<PackageName, PackageManifest>,
117119
) -> impl Iterator<Item = &'a PackageManifest> {
@@ -132,7 +134,7 @@ impl PackageManifest {
132134
})
133135
}
134136

135-
pub fn transitive_internal_dependency_package_names_exclusive<'a>(
137+
pub(crate) fn transitive_internal_dependency_package_names_exclusive<'a>(
136138
&'a self,
137139
package_manifest_by_package_name: &'a HashMap<PackageName, PackageManifest>,
138140
) -> impl Iterator<Item = &'a PackageManifest> {
@@ -167,7 +169,7 @@ impl PackageManifest {
167169

168170
// REFACTOR: for nearness
169171
// Name of the archive generated by `npm pack`, for example "myscope-a-cool-package-1.0.0.tgz"
170-
pub fn npm_pack_file_basename(&self) -> String {
172+
pub(crate) fn npm_pack_file_basename(&self) -> String {
171173
format!(
172174
"{}-{}.tgz",
173175
self.contents
@@ -179,7 +181,7 @@ impl PackageManifest {
179181
)
180182
}
181183

182-
pub fn unscoped_package_name(&self) -> &str {
184+
pub(crate) fn unscoped_package_name(&self) -> &str {
183185
match &self.contents.name.as_str().rsplit_once('/') {
184186
Some((_scope, name)) => name,
185187
None => &self.contents.name.as_str(),

0 commit comments

Comments
 (0)