Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics to track batches vs singletons in external queue #4269

Open
armanbilge opened this issue Feb 8, 2025 · 0 comments
Open

Add metrics to track batches vs singletons in external queue #4269

armanbilge opened this issue Feb 8, 2025 · 0 comments

Comments

@armanbilge
Copy link
Member

Currently, the external queue holds tasks in two styles:

  • batches, which are enqueued when a local queue spills over
  • singletons, which are enqueued when tasks are scheduled externally (i.e., from blocking threads or from other threadpools)

We want to better understand the makeup of the external pool, to optimize how and when the worker runloop interacts with it. One interesting change is that now that we have integrated timers and I/O into the WSTP, this has removed one of the major sources of singletons.

It also is an important metric for applications e.g. lots of batches may suggest that the system is overloaded—in an ideal world, local queues would never have to spill their work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant