feat: add support for Linux Mint (tnx @hasezoey)

* use promisify, remove wrapper function

* Add support for Linux Mint >= 17
- set "getos" version to git from hasezoey/getos with branch "symlink"

* Update getos?

* Remove commented out code

* remove "async" again

* More cleanup
add "unkown" to getLinuxOSVersionString matching
add "a = b" (whitespace) support for -release files
add function "isLinuxOS"
add structure comment to "getLinuxInfomation"
add extra case for archlinux
add tsdoc to some functions

* Upgrade typescript & ts-jest versions
apply npm run lint -- --fix
more cleanup

* chore: update dependencies

* chore: update eslint configs

* remove "debug: true"

* replace all "/data" with "tmpDir.name"
move "tmp.setGracefulCleanup();" call outside, like other tests

* add "tmp.setGracefulCleanup();" to "resolve-config-test"

* adding cleanup script to clean form all old code & old version of mongodb

* fix lint

Co-authored-by: Pablo Damnhorns <[email protected]>

Author: hasezoey

.eslintrc

@@ -0,0 +1,55 @@
+const path = require('path');
+
+module.exports = {
+  parser: '@typescript-eslint/parser',
+  plugins: ['@typescript-eslint', 'prettier'],
+  extends: [
+    'plugin:@typescript-eslint/recommended',
+    'prettier/@typescript-eslint',
+    'plugin:prettier/recommended',
+  ],
+  parserOptions: {
+    sourceType: 'module',
+    useJSXTextNode: true,
+    project: [
+      path.resolve(__dirname, 'tsconfig.test.json'),
+      path.resolve(__dirname, 'packages/mongodb-memory-server-core/tsconfig.json'),
+    ],
+  },
+  rules: {
+    'no-underscore-dangle': 0,
+    'arrow-body-style': 0,
+    'no-unused-expressions': 0,
+    'no-plusplus': 0,
+    'no-console': 0,
+    'func-names': 0,
+    'comma-dangle': [
+      'error',
+      {
+        arrays: 'always-multiline',
+        objects: 'always-multiline',
+        imports: 'always-multiline',
+        exports: 'always-multiline',
+        functions: 'ignore',
+      },
+    ],
+    'no-prototype-builtins': 0,
+    'prefer-destructuring': 0,
+    'no-else-return': 0,
+    'lines-between-class-members': ['error', 'always', { exceptAfterSingleLine: true }],
+    '@typescript-eslint/explicit-member-accessibility': 0,
+    '@typescript-eslint/no-explicit-any': 0,
+    '@typescript-eslint/no-inferrable-types': 0,
+    '@typescript-eslint/explicit-function-return-type': 0,
+    '@typescript-eslint/no-use-before-define': 0,
+    '@typescript-eslint/no-empty-function': 0,
+  },
+  env: {
+    jasmine: true,
+    jest: true,
+  },
+  globals: {
+    Class: true,
+    Iterator: true,
+  },
+};

.eslintrc.js

@@ -6,5 +6,6 @@
     "javascriptreact",
     { "language": "typescript", "autoFix": true },
     { "language": "typescriptreact", "autoFix": true }
-  ]
+  ],
+  "typescript.tsdk": "node_modules/typescript/lib"
 }

.vscode/settings.json

@@ -5,23 +5,23 @@
   "description": "In-memory MongoDB Server. Designed with testing in mind, the server will allow you to connect your favourite ODM or client library to the MongoDB Server and run integration tests isolated from each other.",
   "repository": "https://github.com/nodkz/mongodb-memory-server",
   "devDependencies": {
-    "@types/jest": "^24.0.19",
-    "@types/mongodb": "^3.3.6",
-    "@types/node": "^12.11.2",
-    "@typescript-eslint/eslint-plugin": "^2.5.0",
-    "@typescript-eslint/parser": "^2.5.0",
+    "@types/jest": "24.0.24",
+    "@types/mongodb": "3.3.13",
+    "@types/node": "12.12.21",
+    "@typescript-eslint/eslint-plugin": "2.12.0",
+    "@typescript-eslint/parser": "2.12.0",
     "cross-env": "^6.0.3",
-    "eslint": "^6.5.1",
-    "eslint-config-prettier": "^6.4.0",
-    "eslint-plugin-prettier": "^3.1.1",
+    "eslint": "6.7.2",
+    "eslint-config-prettier": "6.7.0",
+    "eslint-plugin-prettier": "3.1.2",
     "flowgen": "^1.10.0",
     "jest": "^24.9.0",
-    "lerna": "^3.18.2",
-    "mongodb": "^3.2.7",
+    "lerna": "3.19.0",
+    "mongodb": "3.4.0",
     "npm-run-all": "^4.1.5",
-    "prettier": "^1.18.2",
-    "ts-jest": "^24.1.0",
-    "typescript": "^3.6.4"
+    "prettier": "1.19.1",
+    "ts-jest": "^24.2.0",
+    "typescript": "^3.7.3"
   },
   "workspaces": {
     "packages": [
@@ -31,7 +31,8 @@
   "scripts": {
     "test": "lerna run test --stream",
     "lint": "lerna run lint --stream",
-    "watch": "jest --watch",
+    "watch": "jest --env node --watch",
+    "jest": "jest --env node",
     "build": "tsc --build tsconfig.build.json",
     "release": "yarn build && lerna publish",
     "postinstall": "yarn build"

package.json

@@ -34,12 +34,11 @@
     "@types/find-cache-dir": "^2.0.0",
     "@types/find-package-json": "^1.1.0",
     "@types/get-port": "^4.0.1",
-    "@types/getos": "^3.0.0",
     "@types/lockfile": "^1.0.1",
     "@types/md5-file": "^4.0.0",
     "@types/mkdirp": "^0.5.2",
     "@types/tmp": "0.1.0",
-    "@types/uuid": "^3.4.5",
+    "@types/uuid": "3.4.6",
     "rimraf": "^3.0.0"
   },
   "dependencies": {
@@ -48,11 +47,10 @@
     "debug": "^4.1.1",
     "decompress": "^4.2.0",
     "dedent": "^0.7.0",
-    "find-cache-dir": "^3.0.0",
+    "find-cache-dir": "3.2.0",
     "find-package-json": "^1.2.0",
-    "get-port": "^5.0.0",
-    "getos": "^3.1.1",
-    "https-proxy-agent": "^3.0.0",
+    "get-port": "5.0.0",
+    "https-proxy-agent": "4.0.0",
     "lockfile": "^1.0.4",
     "md5-file": "^4.0.0",
     "mkdirp": "^0.5.1",
@@ -63,6 +61,7 @@
     "mongodb": "^3.2.7"
   },
   "scripts": {
+    "cleanup": "rimraf tmp lib coverage node_modules/.cache",
     "build": "npm-run-all build:*",
     "build:ts": "rimraf ./lib && tsc -p ./tsconfig.json",
     "disabled-build:flow": "find ./lib -name \"*.d.ts\" -exec bash -c './node_modules/.bin/flowgen --add-flow-header \"$1\" -o \"${1%.d.ts}\".js.flow' - '{}' \\;",

packages/mongodb-memory-server-core/package.json

@@ -1,19 +1,19 @@
-import getos from 'getos';
+import getOS, { AnyOS, LinuxOS } from './getos';
 import { execSync } from 'child_process';
 import resolveConfig from './resolve-config';
 
 export interface MongoBinaryDownloadUrlOpts {
   version: string;
   platform: string;
   arch: string;
-  os?: getos.Os;
+  os?: AnyOS;
 }
 
 export default class MongoBinaryDownloadUrl {
   platform: string;
   arch: string;
   version: string;
-  os: getos.Os | undefined;
+  os: AnyOS | undefined;
 
   constructor({ platform, arch, version, os }: MongoBinaryDownloadUrlOpts) {
     this.version = version;
@@ -83,10 +83,13 @@ export default class MongoBinaryDownloadUrl {
     let name = `mongodb-linux`;
     name += `-${this.arch}`;
 
-    let osString;
+    let osString: string | undefined;
     if (this.arch !== 'i686') {
-      if (!this.os) this.os = await this.getos();
-      osString = this.getLinuxOSVersionString(this.os as getos.LinuxOs);
+      if (!this.os) {
+        this.os = await getOS();
+        console.log('got back:', this.os);
+      }
+      osString = this.getLinuxOSVersionString(this.os as LinuxOS);
     }
     if (osString) {
       name += `-${osString}`;
@@ -97,16 +100,7 @@ export default class MongoBinaryDownloadUrl {
     return name;
   }
 
-  async getos(): Promise<getos.Os> {
-    return new Promise((resolve, reject) => {
-      getos((e: any, os: any) => {
-        if (e) reject(e);
-        resolve(os);
-      });
-    });
-  }
-
-  getLinuxOSVersionString(os: getos.LinuxOs): string {
+  getLinuxOSVersionString(os: LinuxOS): string {
     if (/ubuntu/i.test(os.dist)) {
       return this.getUbuntuVersionString(os);
     } else if (/elementary OS/i.test(os.dist)) {
@@ -121,15 +115,22 @@ export default class MongoBinaryDownloadUrl {
       return this.getDebianVersionString(os);
     } else if (/mint/i.test(os.dist)) {
       return this.getMintVersionString(os);
+    } else if (/unkown/i.test(os.dist)) {
+      // in some cases this is redundant, but this is here to notify users to report if their Distro couldnt be parsed
+      console.warn(
+        'Couldnt parse dist infomation, please report this to https://github.com/nodkz/mongodb-memory-server/issues'
+      );
     }
+    // this is when the os.dist couldnt be handled by MongoBinaryDownloadUrl
     console.warn(`Unknown linux distro ${os.dist}, falling back to legacy MongoDB build`);
+
     return this.getLegacyVersionString(os);
   }
 
-  getDebianVersionString(os: getos.Os): string {
+  getDebianVersionString(os: LinuxOS): string {
     let name = 'debian';
-    const release: number = parseFloat((os as getos.LinuxOs).release);
-    if (release >= 10 || (os as getos.LinuxOs).release === 'unstable') {
+    const release: number = parseFloat(os.release);
+    if (release >= 10 || os.release === 'unstable') {
       name += '10';
     } else if (release >= 9) {
       name += '92';
@@ -141,9 +142,9 @@ export default class MongoBinaryDownloadUrl {
     return name;
   }
 
-  getFedoraVersionString(os: getos.Os): string {
+  getFedoraVersionString(os: LinuxOS): string {
     let name = 'rhel';
-    const fedoraVer: number = parseInt((os as getos.LinuxOs).release, 10);
+    const fedoraVer: number = parseInt(os.release, 10);
     if (fedoraVer > 18) {
       name += '70';
     } else if (fedoraVer < 19 && fedoraVer >= 12) {
@@ -154,9 +155,9 @@ export default class MongoBinaryDownloadUrl {
     return name;
   }
 
-  getRhelVersionString(os: getos.Os): string {
+  getRhelVersionString(os: LinuxOS): string {
     let name = 'rhel';
-    const { release } = os as getos.LinuxOs;
+    const { release } = os;
     if (release) {
       if (/^7/.test(release)) {
         name += '70';
@@ -170,35 +171,53 @@ export default class MongoBinaryDownloadUrl {
   }
 
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  getElementaryOSVersionString(os: getos.Os): string {
+  getElementaryOSVersionString(os: LinuxOS): string {
     const ubuntuVersion = execSync('/usr/bin/lsb_release -u -rs');
     return `ubuntu${ubuntuVersion
       .toString()
       .replace('.', '')
       .trim()}`;
   }
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  getMintVersionString(os: getos.Os): string {
-    // unfortunately getos doesn't return version for Mint
-    return 'ubuntu1404';
+  getMintVersionString(os: LinuxOS): string {
+    let name = 'ubuntu';
+    const mintMajorVer = parseInt(os.release ? os.release.split('.')[0] : os.release);
+    if (mintMajorVer < 17) {
+      throw new Error('Mint Versions under 17 are not supported!');
+    }
+
+    switch (mintMajorVer) {
+      case 17:
+        name += '1404';
+        break;
+      case 18:
+        name += '1604';
+        break;
+      case 19:
+      default:
+        // a default to support versions > 19
+        name += '1804';
+        break;
+    }
+
+    return name;
   }
 
   // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  getLegacyVersionString(os: getos.Os): string {
+  getLegacyVersionString(os: AnyOS): string {
     return '';
   }
 
-  getSuseVersionString(os: getos.Os): string {
-    const releaseMatch: RegExpMatchArray | null = (os as getos.LinuxOs).release.match(/(^11|^12)/);
+  getSuseVersionString(os: LinuxOS): string {
+    const releaseMatch: RegExpMatchArray | null = os.release.match(/(^11|^12)/);
 
     if (releaseMatch) {
       return `suse${releaseMatch[0]}`;
     }
     return '';
   }
 
-  getUbuntuVersionString(os: getos.LinuxOs): string {
+  getUbuntuVersionString(os: LinuxOS): string {
     let name = 'ubuntu';
     const ubuntuVer: string[] = os.release ? os.release.split('.') : [];
     const majorVer: number = parseInt(ubuntuVer[0], 10);

packages/mongodb-memory-server-core/src/util/MongoBinaryDownloadUrl.ts

@@ -50,7 +50,7 @@ MONGOMS_MD5_CHECK environment variable`, () => {
     expect(du.httpDownload).toHaveBeenCalledTimes(1);
     const callArg1 = (du.httpDownload as jest.Mock).mock.calls[0][0];
     expect(callArg1.agent).toBeDefined();
-    expect(callArg1.agent.options.href).toBe('http://user:pass@proxy:8080/');
+    expect(callArg1.agent.proxy.href).toBe('http://user:pass@proxy:8080/');
   });
 
   it(`makeMD5check returns true if md5 of downloaded mongoDBArchive is