fix: lint

Author: hasezoey

.vscode/tasks.json

@@ -1,25 +1,14 @@
 {
-  // See https://go.microsoft.com/fwlink/?LinkId=733558
-  // for the documentation about the tasks.json format
-  "version": "2.0.0",
-  "tasks": [
+	"version": "2.0.0",
+	"tasks": [
     {
-      "label": "Eslint checks",
-      "type": "shell",
-      "command": "./node_modules/.bin/eslint 'packages/*/src/**/*.{js,ts,tsx}'",
-      "problemMatcher": ["$eslint-stylish"],
-      "isBackground": true,
-      "presentation": {
-        "reveal": "never"
-      },
-      "runOptions": {
-        "reevaluateOnRerun": true,
-        "runOn": "folderOpen"
-      },
-      "group": {
-        "kind": "build",
-        "isDefault": true
-      }
+      "type": "npm",
+      "script": "lint",
+      "problemMatcher": [
+        "$eslint-stylish"
+      ],
+      "label": "npm: lint",
+      "detail": "lerna run lint"
     }
   ]
 }

jest.config.js

@@ -14,5 +14,5 @@ module.exports = {
   roots: ['<rootDir>/src'],
   testPathIgnorePatterns: ['/node_modules/', '/lib/'],
   testMatch: ['**/__tests__/**/*-test.(ts|js)'],
-  projects: ['packages/*'],
+  projects: ['packages/**/*'],
 };

package.json

@@ -30,7 +30,7 @@
   },
   "scripts": {
     "test": "lerna run test --stream",
-    "lint": "lerna run lint --stream",
+    "lint": "lerna run lint --stream --npm-client=yarn --no-prefix",
     "watch": "jest --env node --watch",
     "jest": "jest --env node",
     "build": "tsc --build tsconfig.build.json",

packages/mongodb-memory-server-core/package.json

@@ -83,7 +83,6 @@
     "cleanup": "rimraf tmp lib coverage node_modules/.cache",
     "build": "npm-run-all build:*",
     "build:ts": "rimraf ./lib && tsc -p ./tsconfig.build.json",
-    "disabled-build:flow": "find ./lib -name \"*.d.ts\" -exec bash -c './node_modules/.bin/flowgen --add-flow-header \"$1\" -o \"${1%.d.ts}\".js.flow' - '{}' \\;",
     "watch": "cross-env MONGOMS_DOWNLOAD_DIR=./tmp jest --watchAll",
     "coverage": "cross-env MONGOMS_DOWNLOAD_DIR=./tmp jest --coverage",
     "lint": "npm run eslint && npm run tscheck",

packages/mongodb-memory-server-core/src/MongoMemoryReplSet.ts

@@ -224,7 +224,7 @@ export default class MongoMemoryReplSet extends EventEmitter {
 
     let MongoClient: typeof mongodb.MongoClient;
     try {
-      MongoClient = require('mongodb').MongoClient;
+      MongoClient = (await import('mongodb')).MongoClient;
     } catch (e) {
       throw new Error(
         `You need to install "mongodb" package. It's required for checking ReplicaSet state.`

packages/mongodb-memory-server-core/src/util/MongoBinary.ts

@@ -51,7 +51,7 @@ export default class MongoBinary {
     return this.cache[version];
   }
 
-  static async getDownloadPath(options: any): Promise<string> {
+  static async getDownloadPath(options: Required<MongoBinaryOpts>): Promise<string> {
     const { downloadDir, platform, arch, version } = options;
     // create downloadDir if not exists
     await mkdirp(downloadDir);

packages/mongodb-memory-server-core/src/util/MongoBinaryDownload.ts

@@ -121,7 +121,7 @@ export default class MongoBinaryDownload {
       return undefined;
     }
     const mongoDBArchiveMd5 = await this.download(urlForReferenceMD5);
-    const signatureContent = fs.readFileSync(mongoDBArchiveMd5).toString('UTF-8');
+    const signatureContent = fs.readFileSync(mongoDBArchiveMd5).toString('utf-8');
     const m = signatureContent.match(/(.*?)\s/);
     const md5Remote = m ? m[1] : null;
     const md5Local = md5File.sync(mongoDBArchive);
@@ -208,15 +208,17 @@ export default class MongoBinaryDownload {
       await this.extractZip(mongoDBArchive, extractDir, filter);
     } else {
       throw new Error(
-        `MongoBinaryDownload: unsupported archive ${mongoDBArchive} (downloaded from ${this
-          ._downloadingUrl ?? 'unkown'}). Broken archive from MongoDB Provider?`
+        `MongoBinaryDownload: unsupported archive ${mongoDBArchive} (downloaded from ${
+          this._downloadingUrl ?? 'unkown'
+        }). Broken archive from MongoDB Provider?`
       );
     }
 
     if (!(await this.locationExists(path.resolve(this.downloadDir, this.version, binaryName)))) {
       throw new Error(
-        `MongoBinaryDownload: missing mongod binary in ${mongoDBArchive} (downloaded from ${this
-          ._downloadingUrl ?? 'unkown'}). Broken archive from MongoDB Provider?`
+        `MongoBinaryDownload: missing mongod binary in ${mongoDBArchive} (downloaded from ${
+          this._downloadingUrl ?? 'unkown'
+        }). Broken archive from MongoDB Provider?`
       );
     }
     return extractDir;
@@ -314,7 +316,8 @@ export default class MongoBinaryDownload {
       const fileStream = fs.createWriteStream(tempDownloadLocation);
 
       https
-        .get(httpOptions, (response) => {
+        .get(httpOptions as any, (response) => {
+          // "as any" because otherwise the "agent" wouldnt match
           if (response.statusCode != 200) {
             if (response.statusCode === 403) {
               reject(
@@ -376,7 +379,7 @@ export default class MongoBinaryDownload {
    * Print the Download Progress to STDOUT
    * @param chunk A chunk to get the length
    */
-  printDownloadProgress(chunk: any): void {
+  printDownloadProgress(chunk: { length: number }): void {
     this.dlProgress.current += chunk.length;
 
     const now = Date.now();

packages/mongodb-memory-server-core/src/util/MongoBinaryDownloadUrl.ts

@@ -234,10 +234,7 @@ export default class MongoBinaryDownloadUrl {
       // confirm it is actually a version, otherwise throw an error
       parseFloat(ubuntuVersion.toString());
 
-      return `ubuntu${ubuntuVersion
-        .toString()
-        .replace('.', '')
-        .trim()}`;
+      return `ubuntu${ubuntuVersion.toString().replace('.', '').trim()}`;
     } catch (err) {
       console.error('ElementaryOS "lsb_relese -u -rs" couldnt be executed!');
       throw err;

packages/mongodb-memory-server-core/src/util/MongoInstance.ts

@@ -43,7 +43,7 @@ export default class MongoInstance {
 
   childProcess: ChildProcess | null;
   killerProcess: ChildProcess | null;
-  waitForPrimaryResolveFns: Function[];
+  waitForPrimaryResolveFns: ((value: boolean) => void)[];
   isInstancePrimary: boolean = false;
   isInstanceReady: boolean = false;
   instanceReady: EmptyVoidCallback = () => {};

packages/mongodb-memory-server-core/src/util/db_util.ts

@@ -19,7 +19,7 @@ export function getHost(uri: string): string {
 /**
  * Basic MongoDB Connection string
  */
-export function getUriBase(host: string, port: number, dbName: string) {
+export function getUriBase(host: string, port: number, dbName: string): string {
   return `mongodb://${host}:${port}/${dbName}?`;
 }