Merge pull request #218 from typed-ember/error-loop

Avoid an infinite loop when requesting compiler options

Author: dfreeman

lib/incremental-typescript-compiler/index.js

@@ -29,6 +29,7 @@ module.exports = class IncrementalTypescriptCompiler {
 
     this._ts = project.require('typescript');
     this._watchProgram = null;
+    this._compilerOptions = null;
   }
 
   treeForHost() {
@@ -115,6 +116,10 @@ module.exports = class IncrementalTypescriptCompiler {
         }
       }
     });
+
+    // Prefetch the compiler options, because fetching them while reporting a diagnostic
+    // can result in a diagnostic-reporting loop in certain states
+    this._compilerOptions = this.getProgram().getCompilerOptions();
   }
 
   getProgram() {
@@ -130,8 +135,7 @@ module.exports = class IncrementalTypescriptCompiler {
   }
 
   _shouldFailOnTypeError() {
-    let options = this.getProgram().getCompilerOptions();
-    return !!options.noEmitOnError;
+    return !!this._compilerOptions.noEmitOnError;
   }
 
   _mirageDirectory() {