Skip to content

Commit e906d4d

Browse files
committed
implemented twin-elements/crud-logger
1 parent 3d3c9d0 commit e906d4d

3 files changed

Lines changed: 21 additions & 17 deletions

File tree

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@
1212
"require": {
1313
"php": "^7.1.3",
1414
"symfony/framework-bundle": "^4.4 || ^5.4",
15-
"twin-elements/admin-bundle": "^1.9"
15+
"twin-elements/admin-bundle": "^1.11"
1616
},
1717
"autoload": {
1818
"psr-4": {
1919
"TwinElements\\MenuBundle\\": "src/"
2020
}
2121
},
2222
"conflict": {
23-
"twin-elements/admin-bundle": "<1.9"
23+
"twin-elements/admin-bundle": "<1.11.3"
2424
}
2525
}

src/Controller/MenuCategoryController.php

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@
22

33
namespace TwinElements\MenuBundle\Controller;
44

5+
use Doctrine\Persistence\ManagerRegistry;
56
use TwinElements\AdminBundle\Model\CrudControllerTrait;
67
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
78
use Symfony\Component\Routing\Annotation\Route;
89
use Symfony\Component\HttpFoundation\Request;
910
use TwinElements\AdminBundle\Role\AdminUserRole;
11+
use TwinElements\Component\CrudLogger\CrudLogger;
1012
use TwinElements\MenuBundle\Entity\MenuCategory;
1113
use TwinElements\MenuBundle\Form\MenuCategoryType;
1214
use TwinElements\MenuBundle\Repository\MenuCategoryRepository;
@@ -38,7 +40,9 @@ public function indexAction(MenuCategoryRepository $menuCategoryRepository)
3840
/**
3941
* @Route("/new", name="menucategory_new", methods={"GET", "POST"})
4042
*/
41-
public function newAction(Request $request)
43+
public function newAction(
44+
ManagerRegistry $managerRegistry,
45+
Request $request)
4246
{
4347
$this->denyAccessUnlessGranted("ROLE_SUPER_ADMIN");
4448
$menuCategory = new Menucategory();
@@ -48,12 +52,12 @@ public function newAction(Request $request)
4852
if ($form->isSubmitted() && $form->isValid()) {
4953

5054
try {
51-
$em = $this->getDoctrine()->getManager();
55+
$em = $managerRegistry->getManager();
5256
$em->persist($menuCategory);
5357
$em->flush();
5458

5559
$this->flashes->successMessage($this->adminTranslator->translate('admin.success_operation'));;
56-
$this->crudLogger->createLog($menuCategory->getId(), $menuCategory->getTitle());
60+
$this->crudLogger->createLog(MenuCategory::class, CrudLogger::CreateAction, $menuCategory->getId());
5761

5862
} catch (\Exception $exception) {
5963
$this->flashes->errorMessage($exception->getMessage());
@@ -81,7 +85,7 @@ public function newAction(Request $request)
8185
/**
8286
* @Route("/{id}/edit", name="menucategory_edit", methods={"GET", "POST"})
8387
*/
84-
public function editAction(Request $request, MenuCategory $menuCategory)
88+
public function editAction(ManagerRegistry $managerRegistry, Request $request, MenuCategory $menuCategory)
8589
{
8690
$this->denyAccessUnlessGranted(AdminUserRole::ROLE_ADMIN);
8791
$deleteForm = $this->createDeleteForm($menuCategory);
@@ -91,10 +95,10 @@ public function editAction(Request $request, MenuCategory $menuCategory)
9195
if ($editForm->isSubmitted() && $editForm->isValid()) {
9296

9397
try {
94-
$this->getDoctrine()->getManager()->flush();
98+
$managerRegistry->getManager()->flush();
9599

96100
$this->flashes->successMessage($this->adminTranslator->translate('admin.success_operation'));;
97-
$this->crudLogger->createLog($menuCategory->getId(), $menuCategory->getTitle());
101+
$this->crudLogger->createLog(MenuCategory::class, CrudLogger::EditAction, $menuCategory->getId());
98102

99103
} catch (\Exception $exception) {
100104
$this->flashes->errorMessage($exception->getMessage());
@@ -124,7 +128,7 @@ public function editAction(Request $request, MenuCategory $menuCategory)
124128
*
125129
* @Route("/{id}", name="menucategory_delete", methods={"DELETE"})
126130
*/
127-
public function deleteAction(Request $request, MenuCategory $menuCategory)
131+
public function deleteAction(Request $request, MenuCategory $menuCategory, ManagerRegistry $managerRegistry)
128132
{
129133
$this->denyAccessUnlessGranted(AdminUserRole::ROLE_ADMIN);
130134

@@ -136,14 +140,13 @@ public function deleteAction(Request $request, MenuCategory $menuCategory)
136140
try {
137141

138142
$id = $menuCategory->getId();
139-
$title = $menuCategory->getTitle();
140143

141-
$em = $this->getDoctrine()->getManager();
144+
$em = $managerRegistry->getManager();
142145
$em->remove($menuCategory);
143146
$em->flush();
144147

145148
$this->flashes->successMessage($this->adminTranslator->translate('admin.success_operation'));;
146-
$this->crudLogger->createLog($id, $title);
149+
$this->crudLogger->createLog(MenuCategory::class, CrudLogger::DeleteAction, $id);
147150

148151
} catch (\Exception $exception){
149152
$this->flashes->errorMessage($exception->getMessage());

src/Controller/MenuController.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
namespace TwinElements\MenuBundle\Controller;
44

55
use Symfony\Component\Cache\Adapter\AdapterInterface;
6+
use TwinElements\Component\CrudLogger\CrudLogger;
7+
use TwinElements\Component\CrudLogger\CrudLoggerInterface;
68
use TwinElements\SortableBundle\Entity\PositionInterface;
79
use TwinElements\AdminBundle\Helper\Breadcrumbs;
8-
use TwinElements\AdminBundle\Helper\CrudLoggerMessage;
910
use TwinElements\AdminBundle\Model\CrudControllerTrait;
1011
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
1112
use Symfony\Component\Routing\Annotation\Route;
@@ -34,7 +35,7 @@ class MenuController extends AbstractController
3435
CrudControllerTrait::__construct as private __crudConstruct;
3536
}
3637

37-
public function __construct(Breadcrumbs $breadcrumbs, Flashes $flashes, CrudLoggerMessage $crudLogger, AdminTranslator $translator, AdapterInterface $cache)
38+
public function __construct(Breadcrumbs $breadcrumbs, Flashes $flashes, CrudLoggerInterface $crudLogger, AdminTranslator $translator, AdapterInterface $cache)
3839
{
3940
$this->__crudConstruct($breadcrumbs, $flashes, $crudLogger, $translator);
4041
$this->cache = $cache;
@@ -106,7 +107,7 @@ public function newAction(Request $request, AdapterInterface $cache)
106107
}
107108

108109
$this->flashes->successMessage($this->adminTranslator->translate('admin.success_operation'));;
109-
$this->crudLogger->createLog($menu->getId(), $menu->getTitle());
110+
$this->crudLogger->createLog(Menu::class, CrudLogger::CreateAction, $menu->getId());
110111

111112
} catch (\Exception $exception) {
112113
$this->flashes->errorMessage($exception->getMessage());
@@ -164,7 +165,7 @@ public function editAction(Request $request, Menu $menu, AdapterInterface $cache
164165
}
165166

166167
$this->flashes->successMessage($this->adminTranslator->translate('admin.success_operation'));;
167-
$this->crudLogger->createLog($menu->getId(), $menu->getTitle());
168+
$this->crudLogger->createLog(Menu::class, CrudLogger::EditAction, $menu->getId());
168169

169170
} catch (\Exception $exception) {
170171
$this->flashes->errorMessage($exception->getMessage());
@@ -221,7 +222,7 @@ public function deleteAction(Request $request, Menu $menu)
221222

222223
$this->removeCache($category, $request->getLocale());
223224

224-
$this->crudLogger->createLog($id, $title);
225+
$this->crudLogger->createLog(Menu::class, CrudLogger::DeleteAction, $menu->getId());
225226
$this->flashes->successMessage($this->adminTranslator->translate('menu.the_menu_item_has_been_deleted'));
226227
} catch (\Exception $exception) {
227228
$this->flashes->errorMessage($exception->getMessage());

0 commit comments

Comments
 (0)