Skip to content

Commit 3868a78

Browse files
dkundelmakserikVictor Ayogu
authored
fix(twilio-run): turn off fork-process in inspect mode (#462)
* fix(twilio-run): turn off fork-process in inspect mode * Update start.test.ts --------- Co-authored-by: makserik <[email protected]> Co-authored-by: Victor Ayogu <[email protected]>
1 parent 34de081 commit 3868a78

File tree

3 files changed

+26
-0
lines changed

3 files changed

+26
-0
lines changed

.changeset/warm-moles-learn.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'twilio-run': patch
3+
'@twilio-labs/plugin-serverless': patch
4+
---
5+
6+
Fix of debug/inspect mode by disabling fork process

packages/twilio-run/__tests__/config/start.test.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -285,4 +285,18 @@ describe('getConfigFromCli', () => {
285285
expect(startConfig.baseDir).toEqual(path.resolve(config.cwd));
286286
}
287287
});
288+
289+
test('turns off fork process if inspect is enabled', async () => {
290+
require('../../src/config/utils/package-json').__setPackageJson({});
291+
const config = {
292+
dir: './other_dir',
293+
inspect: '',
294+
} as unknown as StartCliFlags;
295+
if (config.dir) {
296+
const startConfig = await getConfigFromCli(config);
297+
expect(startConfig.baseDir).toEqual(path.resolve(config.dir));
298+
expect(startConfig.forkProcess).toEqual(false);
299+
expect(startConfig.inspect).not.toEqual(undefined);
300+
}
301+
});
288302
});

packages/twilio-run/src/config/start.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,12 @@ export async function getConfigFromCli(
186186
config.assetsFolderName = cli.assetsFolder;
187187
config.functionsFolderName = cli.functionsFolder;
188188
config.forkProcess = cli.forkProcess;
189+
190+
if (typeof config.inspect !== 'undefined') {
191+
debug('Disabling fork-process in inspect mode.');
192+
config.forkProcess = false;
193+
}
194+
189195
config.pkgJson = pkgJson;
190196

191197
return config;

0 commit comments

Comments
 (0)