Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create Duplicate queries for every object #9828

Open
FelixMalfait opened this issue Jan 24, 2025 · 1 comment
Open

Don't create Duplicate queries for every object #9828

FelixMalfait opened this issue Jan 24, 2025 · 1 comment

Comments

@FelixMalfait
Copy link
Member

We shouldn't create a duplicate queries for every object like we do today:

Image

For now I think a good think would be to at least filter out on isSystem. If the object is a system object then we don't want to create these queries.

@etiennejouan
Copy link
Contributor

etiennejouan commented Feb 3, 2025

Implementation plan :

  • Create @WorkspaceDuplicateCriteria() decorator - with duplicate criteria as input
  • Update buildDuplicateConditions logic
  • Add it to all Companies, People and Opportunities
  • In workspace-resolver.factory, add a new shouldCreateQueryResolver(methodName, objectMetaData) method - disable 'duplicate' method if object doesn't have decorator

@etiennejouan etiennejouan moved this to 🔖 Planned in 🎯 Roadmap & Sprints Feb 3, 2025
@etiennejouan etiennejouan moved this from 🔖 Planned to 🏗 In Progress in 🎯 Roadmap & Sprints Feb 5, 2025
@etiennejouan etiennejouan moved this from 🏗 In Progress to 🔖 Planned in 🎯 Roadmap & Sprints Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Planned
Development

No branches or pull requests

2 participants