Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Record Filter and Record Sort #40

Open
3 of 12 tasks
lucasbordeau opened this issue Oct 17, 2024 · 4 comments
Open
3 of 12 tasks

Refactor Record Filter and Record Sort #40

lucasbordeau opened this issue Oct 17, 2024 · 4 comments

Comments

@lucasbordeau
Copy link

lucasbordeau commented Oct 17, 2024

Master issue for the refactor of record filters and record sorts.

Goals of this refactor :

  • Remove component state v1 from record filter and record sort states.
  • Progressively rollout a V2 handling of record filters and record sorts that is acting in parallel, so we only have to switch to V2 from V1 without breaking anything
  • Have record filters and record sorts act as standalone modules and also standalone contexts, that can be used by other related modules : index, table, kanban, view, context store.

ViewFilter and RecordFilter are two concepts that are used in the view module.

They are required to keep the database ViewFilter concept and the UI Filter concept separated, but right now we could have a better abstraction of ViewFilter.

Because in the UI we manipulate almost always RecordFilters, and we could have it turned into ViewFilter and back again so that we never manipulate ViewFilter directly.

@ad-elias
Copy link

Could I work on this!

@FelixMalfait
Copy link
Member

Great thanks a lot Elias! You can work on that in November when you come back that'd be great!

@lucasbordeau
Copy link
Author

@FelixMalfait @ad-elias I'll take it because we need to be very precise about it with @charlesBochet and we already discussed implementation details, also I'll be refactoring related things this sprint.

@FelixMalfait
Copy link
Member

Perfect thank you @lucasbordeau

@lucasbordeau lucasbordeau changed the title Refactor ViewFilter and Filter Refactor Record Filter Nov 26, 2024
@Bonapara Bonapara transferred this issue from twentyhq/twenty Jan 10, 2025
@lucasbordeau lucasbordeau marked this as a duplicate and then as not a duplicate of #41 Jan 20, 2025
@lucasbordeau lucasbordeau changed the title Refactor Record Filter Refactor Record Filter and Record Sort Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants