Skip to content

Commit 534a469

Browse files
authoredFeb 8, 2024
Merge pull request #2120 from tweag/ylecornec/bcr_presubmit
Update presubmit.yml for the BCR
2 parents 3a2cad0 + 6652e23 commit 534a469

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed
 

‎.bcr/presubmit.yml

+10
Original file line numberDiff line numberDiff line change
@@ -7,21 +7,31 @@ matrix:
77
# disable Windows for now, it fails with
88
# "this rule is missing dependency declarations for the following files ..."
99
#- windows
10+
bazel:
11+
- 6.x
1012
tasks:
1113
verify_targets:
1214
name: Verify build targets
1315
platform: ${{ platform }}
16+
bazel: ${{ bazel }}
1417
shell_commands:
1518
- |
1619
if apt --version >/dev/null 2>/dev/null; then
1720
sudo apt update
1821
sudo apt install --no-install-recommends -yy libtinfo5 libgmp-dev
1922
fi
23+
- |
24+
if xcodebuild -version; then
25+
# Setup xcode because GHC bindists expect the following directory on mac:
26+
# /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/ffi
27+
xcodebuild -runFirstLaunch
28+
fi
2029
batch_commands:
2130
# enforce certificate update
2231
- 'powershell -Command "Invoke-WebRequest -Uri https://hackage.haskell.org/root.json -OutFile out.json"'
2332
build_flags:
2433
- '--incompatible_enable_cc_toolchain_resolution'
34+
- '--repo_env=BAZEL_USE_CPP_ONLY_TOOLCHAIN=1'
2535
build_targets:
2636
- '@rules_haskell//haskell/...'
2737
- '@rules_haskell//tools/...'

‎.github/ISSUE_TEMPLATE/release.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ about: Steps to work through in order to publish a new release
99
- [ ] Create and checkout a new release preparation branch, named
1010
`release-<major>.<minor>`.
1111
- [ ] If the minimal Bazel version has changed:
12-
- [ ] update it in [the `start` script][start], in [`haskell/private/versions.bzl`][versions], and in [the `README`][readme]
12+
- [ ] update it in [the `start` script][start], in [`haskell/private/versions.bzl`][versions], in [the `README`][readme] and in `presubmit.yml` files from the `.bcr` folder
1313
- [ ] add a note about this change to the [`CHANGELOG`][changelog]
1414
- [ ] Remove any feature that is still too experimental to go into a
1515
release, by cherry-picking reverts (or by manually deleting the

0 commit comments

Comments
 (0)