fix(phase3): enable polling when decisions stream from Phase 2#34
Merged
fix(phase3): enable polling when decisions stream from Phase 2#34
Conversation
Phase 3 wasn't updating the UI for blocks 2+ when decisions were streaming in from Phase 2's background worker. The polling timer never started because initialization logic incorrectly marked all blocks as "ready" when it detected a non-empty decisions list. Root Cause: The initialization code (lines 167-174) assumed only two scenarios: 1. Empty decisions → streaming will start, don't mark blocks ready 2. Non-empty decisions → complete pre-generated list (tests), mark ALL ready But there was a third scenario it didn't handle: 3. Partially populated decisions → streaming from Phase 2, only mark blocks WITH decisions as ready This caused on_mount() to calculate all_complete=True (5 ready / 5 total), preventing the polling timer from starting. Fix: 1. Use auto_start_workers flag to distinguish test mode (True) from production mode with shared streaming list (False) 2. In production mode, only mark blocks with decisions as ready 3. Change task check from isinstance() to hasattr() to support test MockApp Result: - Polling starts correctly when blocks_ready < total_blocks - UI updates as new decisions stream in from Phase 2 - All 56 Phase 3 tests pass Assisted-by: Claude Code
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 84.57% 84.75% +0.18%
==========================================
Files 48 48
Lines 5083 5084 +1
==========================================
+ Hits 4299 4309 +10
+ Misses 784 775 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3 wasn't updating the UI for blocks 2+ when decisions were streaming in from Phase 2's background worker. The polling timer never started because initialization logic incorrectly marked all blocks as "ready" when it detected a non-empty decisions list.
Root Cause:
The initialization code (lines 167-174) assumed only two scenarios:
But there was a third scenario it didn't handle:
3. Partially populated decisions → streaming from Phase 2, only mark blocks WITH decisions as ready
This caused on_mount() to calculate all_complete=True (5 ready / 5 total), preventing the polling timer from starting.
Fix:
Result:
Assisted-by: Claude Code