Retry media downloads on HTTP2 errors

tulir · tulir · commit c4c420e0226e · 2024-03-26T16:17:17.000+02:00
diff --git a/download.go b/download.go
@@ -269,6 +269,7 @@ func shouldRetryMediaDownload(err error) bool {
 	var netErr net.Error
 	var httpErr DownloadHTTPError
 	return errors.As(err, &netErr) ||
+		strings.HasPrefix(err.Error(), "stream error:") || // hacky check for http2 errors
 		(errors.As(err, &httpErr) && retryafter.Should(httpErr.StatusCode, true))
 }
 

Original file line number	Diff line number	Diff line change
`@@ -269,6 +269,7 @@ func shouldRetryMediaDownload(err error) bool {`
`269`	`269`	`var netErr net.Error`
`270`	`270`	`var httpErr DownloadHTTPError`
`271`	`271`	`return errors.As(err, &netErr) \|\|`
	`272`	`+ strings.HasPrefix(err.Error(), "stream error:") \|\| // hacky check for http2 errors`
`272`	`273`	`(errors.As(err, &httpErr) && retryafter.Should(httpErr.StatusCode, true))`
`273`	`274`	`}`
`274`	`275`