Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant typing lag when large scrollback buffer #2

Open
AdamWagner opened this issue May 2, 2020 · 1 comment
Open

Significant typing lag when large scrollback buffer #2

AdamWagner opened this issue May 2, 2020 · 1 comment

Comments

@AdamWagner
Copy link

AdamWagner commented May 2, 2020

To reproduce:

# navigate to home directory 
# and print a large amount of content to the screen. E.g.,
cd ~
tree

# invoke the search kitten and type a query

When I follow the steps above, there is a significant (700ms?) delay between pressing a key a the character appearing on the screen. Such a delay makes it difficult to type without making an error.

I do not have this issue on a fresh tab with a small amount (e.g., ls) of content in the scrollback buffer.

If you're able to reproduce this, perhaps search should be executed asynchronously so that user input isn't blocked.

@trygveaa
Copy link
Owner

trygveaa commented May 3, 2020

It's not just the kitten that hangs, it's all of kitty, so it won't help to execute the search asynchronously unfortunately.

So apart from solving the issue in kitty, I think the search kitten itself has these two potential solutions:

  1. Disable incremental search when the scrollback is large.
  2. Implement a debounce, so it doesn't search until after you've stopped typing for a short while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants