Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging out directs you back to the keycloak login UI #37

Open
ctron opened this issue May 24, 2024 · 3 comments
Open

Logging out directs you back to the keycloak login UI #37

ctron opened this issue May 24, 2024 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. V1-UI Parity

Comments

@ctron
Copy link
Contributor

ctron commented May 24, 2024

Steps to reproduce:

  • Enable authentication with Keycloak
  • Do the whole login flow
  • Then press logout in the UI
  • 🔥 The UI redirects you back to the Keycloak login screen

My expectation would be:

  • That the user is logged out
  • That the user gets a confirmation that the logout was successful
  • Maybe gets a button/link to "log in again"
  • But does NOT get automatically forwarded to the login screen again
@carlosthe19916
Copy link
Member

@ctron where this requirement is coming from? I don't think this is a user friendly thing to do. We are doing 2 steps thing for the user to go back to the login page once he log out.

I believe this is the approach taken in v1 and I think it was not an ideal way of doing things.

Benefits of redirecting to the login page

  • Clarity: it is clear the user is no longer logged in and it provides an immediate way of login if needed.
  • Convenience: the login page is the ONLY page where the user can go after log out. We do not expect the user to navigate to any other page as all pages are protected.
  • User experience: it creates a clear end to end session and the message of "You are logged out" is 100% clear.

What is being requested:

My expectation would be:
That the user is logged out
That the user gets a confirmation that the logout was successful
Maybe gets a button/link to "log in again"
But does NOT get automatically forwarded to the login screen again

  • It forces the user to do unnecessarily 2 steps for going back to the login page:
    • First step: user click on "Log out". He is redirected to a page that has a button/link to "log in again" (as suggested in this issue)
    • Second step: the user clicks on "Log in again". And he is redirected to the Keycloak login page
    • Third step: user enters his username/password to be logged in again.

So:

  • What problem are we solving forcing the user to do a 2 steps process?
  • Exactly how the user benefits from using the 2 steps process suggested that he can not have with the current 1 step process that we have?

@ctron
Copy link
Contributor Author

ctron commented Nov 19, 2024

@ctron where this requirement is coming from?

Parity with v1.

@carlosthe19916 carlosthe19916 added kind/bug Categorizes issue or PR as related to a bug. and removed bug labels Feb 18, 2025
@trustification-ci-bot trustification-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 18, 2025
@trustification-ci-bot
Copy link
Contributor

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@trustification-ci-bot trustification-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Feb 18, 2025
@carlosthe19916 carlosthe19916 added this to the Trustify 2.0.0 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. V1-UI Parity
Projects
Status: Ready
Development

No branches or pull requests

2 participants