Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings from npm install step #17

Open
helio-frota opened this issue May 17, 2024 · 4 comments
Open

Remove warnings from npm install step #17

helio-frota opened this issue May 17, 2024 · 4 comments

Comments

@helio-frota
Copy link
Collaborator

➜  trustify-ui git:(main) ✗ npm i
npm WARN deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated [email protected]: Use your platform's native atob() and btoa() methods instead
npm WARN deprecated [email protected]: Use your platform's native DOMException instead
  • npm WARN deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated
  • npm WARN deprecated [email protected]: Use your platform's native atob() and btoa() methods instead
  • npm WARN deprecated [email protected]: Use your platform's native DOMException instead
@carlosthe19916
Copy link
Member

What problem are we solving removing the warnings? I am not a fan of wasting time on tasks that add no value to the app. Unless we identity a bug or a real problem I do not think we should invest a minute on it.

@helio-frota
Copy link
Collaborator Author

I understand your point but currently we can't just update the deps without breaking ts compilation and other webpack parts.

So I'm splitting the problem in small parts 👍

@helio-frota helio-frota self-assigned this May 17, 2024
@ctron
Copy link
Contributor

ctron commented May 17, 2024

What problem are we solving removing the warnings?

We don't seem to know, right? However, ignoring warnings feels like bad strategy. Someone might have a reason for "warning" others. Go going ahead and cleaning up warnings is an important task IMHO.

Cleaning up can come in two ways: replacing the dependency, or figuring out that there's no harm. In the latter case, the warning should be silenced. If technically not possible, there should be a note somewhere.

Personally I find builds with warnings quite distracting and suspicious.

@helio-frota
Copy link
Collaborator Author

Someone might have a reason for "warning" others

yeah I found some things already... and that is not only related to update the version numbers.. some of them are dropping support for node < 18 and etc...

similar to this task https://gist.github.com/helio-frota/dab8edd2b1862bcbb6567e2cb1d29e1e#http where we need to read the change-log-release docs , build, run etc etc .

imo, its not a good thing to spent hours (days?) in future ~6 months trying to fix an "unfixable" because good amount of breaking changes...

Personally I find builds with warnings quite distracting and suspicious.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants