Skip to content

Conversation

@WillPelech
Copy link
Contributor

@WillPelech WillPelech commented Nov 14, 2025

Description

This PR adds a test case to BaseConnectorSmokeTest testing that analyze works correctly if the connector supports the operation. If the test fails then it is because of lack of support so the test will then check that the test is indeed true for the underlying connector.

Fixes #27273

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot
Copy link

cla-bot bot commented Nov 14, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the iceberg Iceberg connector label Nov 14, 2025
@cla-bot
Copy link

cla-bot bot commented Nov 20, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@WillPelech WillPelech changed the title Added BaseConnectorSmokeTest for Analyze to test different catalogs Test ANALYZE in BaseIcebergConnectorSmokeTest Nov 20, 2025
@WillPelech
Copy link
Contributor Author

Hi I submitted the CLA around 5 days ago I was wondering how long it takes to get approved?

@cla-bot
Copy link

cla-bot bot commented Nov 24, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@chenjian2664
Copy link
Contributor

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Nov 24, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link

cla-bot bot commented Nov 24, 2025

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr ebyhr force-pushed the BaseSmokeDetectorTest branch from 498f4a0 to 43e6b98 Compare November 27, 2025 10:05
@cla-bot cla-bot bot added the cla-signed label Nov 27, 2025
@ebyhr
Copy link
Member

ebyhr commented Nov 27, 2025

/test-with-secrets sha=43e6b98ba4bbb518289f4d7b215c5bb6c3e6d028

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/19732564071

@ebyhr ebyhr force-pushed the BaseSmokeDetectorTest branch from 43e6b98 to ca1844f Compare November 27, 2025 10:07
@ebyhr
Copy link
Member

ebyhr commented Nov 27, 2025

/test-with-secrets sha=ca1844fab936cfadab3ae276e702332db93cd3e4

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/19732742204

@ebyhr ebyhr force-pushed the BaseSmokeDetectorTest branch from ca1844f to 9e57706 Compare November 27, 2025 23:33
@ebyhr
Copy link
Member

ebyhr commented Nov 27, 2025

/test-with-secrets sha=9e577063d0d8a293aec673cd5aef5d1e07ed77f7

@github-actions
Copy link

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/19749977229

@ebyhr ebyhr merged commit e017b5b into trinodb:master Nov 28, 2025
43 checks passed
@github-actions github-actions bot added this to the 479 milestone Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed iceberg Iceberg connector

Development

Successfully merging this pull request may close these issues.

Test ANALYZE statement in BaseIcebergConnectorSmokeTest

3 participants