Test ANALYZE in BaseIcebergConnectorSmokeTest

Author: WillPelech

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorSmokeTest.java

@@ -56,6 +56,7 @@
 import static com.google.common.base.Verify.verify;
 import static com.google.common.collect.ImmutableList.toImmutableList;
 import static io.airlift.concurrent.MoreFutures.tryGetFutureValue;
+import static io.trino.plugin.iceberg.IcebergSessionProperties.COLLECT_EXTENDED_STATISTICS_ON_WRITE;
 import static io.trino.plugin.iceberg.IcebergTestUtils.FILE_IO_FACTORY;
 import static io.trino.plugin.iceberg.IcebergTestUtils.getFileSystemFactory;
 import static io.trino.plugin.iceberg.IcebergTestUtils.getMetadataFileAndUpdatedMillis;
@@ -893,6 +894,34 @@ public void testIcebergTablesSystemTable()
         }
     }
 
+    @Test
+    public void testAnalyze()
+    {
+        Session noStatsOnWrite = Session.builder(getSession())
+                .setCatalogSessionProperty("iceberg", COLLECT_EXTENDED_STATISTICS_ON_WRITE, "false")
+                .build();
+
+        try (TestTable table = newTrinoTable("test_analyze", "(id int)")) {
+            assertUpdate(noStatsOnWrite, "INSERT INTO " + table.getName() + " VALUES 1, 2, 3", 3);
+
+            try {
+                assertUpdate("ANALYZE " + table.getName());
+            }
+            catch (Exception e) {
+                verifyAnalyzeFailurePermissible(e);
+                return;
+            }
+            assertThat(query("SHOW STATS FOR " + table.getName())).result()
+                    .projected("column_name", "distinct_values_count")
+                    .matches("VALUES (VARCHAR 'id', 3e0), (null, null)");
+        }
+    }
+
+    protected void verifyAnalyzeFailurePermissible(Exception e)
+    {
+        throw new AssertionError("Unexpected analyze failure", e);
+    }
+
     protected void dropSchema(String schema)
             throws Exception
     {

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergS3TablesConnectorSmokeTest.java

@@ -123,6 +123,12 @@ protected void dropTableFromMetastore(String tableName)
         throw new UnsupportedOperationException();
     }
 
+    @Override
+    protected void verifyAnalyzeFailurePermissible(Exception e)
+    {
+        assertThat(e).hasMessageContaining("S3 Tables do not support analyze");
+    }
+
     @Test
     @Override // Override because the location pattern differs
     public void testShowCreateTable()

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/rest/TestIcebergUnityRestCatalogConnectorSmokeTest.java

@@ -548,4 +548,12 @@ public void testMetadataDeleteAfterCommitEnabled()
         assertThatThrownBy(super::testMetadataDeleteAfterCommitEnabled)
                 .hasStackTraceContaining("Access Denied");
     }
+
+    @Test
+    @Override
+    public void testAnalyze()
+    {
+        assertThatThrownBy(super::testAnalyze)
+                .hasStackTraceContaining("Access Denied");
+    }
 }

plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/snowflake/TestIcebergSnowflakeCatalogConnectorSmokeTest.java

@@ -522,6 +522,14 @@ public void testCreateOrReplaceWithTableChangesFunction()
                 .hasMessageMatching("Snowflake managed Iceberg tables do not support modifications");
     }
 
+    @Test
+    @Override
+    public void testAnalyze()
+    {
+        assertThatThrownBy(super::testAnalyze)
+                .hasMessageMatching("Snowflake managed Iceberg tables do not support modifications");
+    }
+
     @Test
     public void testNation()
     {