move shared logic to helper method

Author: amybubu

gateway-ha/src/main/java/io/trino/gateway/ha/resource/GatewayResource.java

@@ -86,7 +86,7 @@ public Response activateBackend(@PathParam("name") String name)
             this.gatewayBackendManager.activateBackend(name);
         }
         catch (Exception e) {
-            log.error(e);
+            log.error(e, e.getMessage());
             return throwError(e);
         }
         return Response.ok().build();

gateway-ha/src/main/java/io/trino/gateway/ha/router/HaGatewayManager.java

@@ -22,9 +22,9 @@
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Objects;
 import java.util.Optional;
 
+import static java.lang.String.format;
 import static java.util.Objects.requireNonNull;
 
 public class HaGatewayManager
@@ -83,24 +83,37 @@ public Optional<ProxyBackendConfiguration> getBackendByName(String name)
     @Override
     public void deactivateBackend(String backendName)
     {
-        GatewayBackend model = dao.findFirstByName(backendName);
-        if (model != null) {
-            Boolean prevStatus = model.active();
-            dao.deactivate(backendName);
-            log.info("Backend cluster %s has been deactivated (previous status: active=%s).",
-                    backendName, prevStatus);
-        }
+        updateClusterActivationStatus(backendName, false, () -> dao.deactivate(backendName));
     }
 
     @Override
     public void activateBackend(String backendName)
     {
-        GatewayBackend model = dao.findFirstByName(backendName);
-        if (model != null) {
-            Boolean prevStatus = model.active();
-            dao.activate(backendName);
-            log.info("Backend cluster %s has been activated (previous status: active=%s).",
-                    backendName, prevStatus);
+        updateClusterActivationStatus(backendName, true, () -> dao.activate(backendName));
+    }
+
+    private void updateClusterActivationStatus(String clusterName, boolean newStatus, Runnable action)
+    {
+        GatewayBackend model = dao.findFirstByName(clusterName);
+        if (model == null) {
+            throw new IllegalStateException(format("No cluster found with name: %s, could not (de)activate", clusterName));
+        }
+
+        boolean prevStatus = model.active();
+        try {
+            action.run();
+            logActivationStatusChange(clusterName, newStatus, prevStatus);
+        }
+        catch (Exception e) {
+            throw e;
+        }
+    }
+
+    private void logActivationStatusChange(String clusterName, boolean newStatus, boolean prevStatus)
+    {
+        if (prevStatus != newStatus) {
+            log.info("Backend cluster %s activation status set to active=%s (previous status: active=%s).",
+                    clusterName, newStatus, prevStatus);
         }
     }
 
@@ -123,13 +136,8 @@ public ProxyBackendConfiguration updateBackend(ProxyBackendConfiguration backend
             dao.create(backend.getName(), backend.getRoutingGroup(), backendProxyTo, backendExternalUrl, backend.isActive());
         }
         else {
-            Boolean prevStatus = model.active();
             dao.update(backend.getName(), backend.getRoutingGroup(), backendProxyTo, backendExternalUrl, backend.isActive());
-            Boolean currStatus = backend.isActive();
-            if (!Objects.equals(prevStatus, currStatus)) {
-                log.info("Backend cluster %s activation status changed to active=%s (previous status: active=%s).",
-                        backend.getName(), currStatus, prevStatus);
-            }
+            logActivationStatusChange(backend.getName(), backend.isActive(), model.active());
         }
         return backend;
     }