Skip to content

Commit 13c19e9

Browse files
authored
Merge pull request #13855 from iyamazaki/basker-float
ShyLU-Basker : fix compile errors/warnings (e.g., with float)
2 parents 75faeee + 4c9ca25 commit 13c19e9

File tree

3 files changed

+33
-45
lines changed

3 files changed

+33
-45
lines changed

packages/shylu/shylu_node/basker/src/mwm2.hpp

+27-38
Original file line numberDiff line numberDiff line change
@@ -533,26 +533,25 @@ namespace mwm_order
533533
template<class Int, class Entry>
534534
int mwm_bn_init
535535
(
536-
Int n,
536+
Int n,
537537
Int nnz,
538-
Int *col_ptr,
538+
Int *col_ptr,
539539
Int *row_idx,
540540
Entry *val,
541-
Int *pr,
541+
Int *pr,
542542
Int *L,
543-
//Entry *d,
544-
double *d,
545-
Int *iperm,
546-
Int *jperm,
547-
Int &num,
548-
double &bv
543+
Entry *d,
544+
Int *iperm,
545+
Int *jperm,
546+
Int &num,
547+
Entry &bv
549548
)
550549
{
551550
Int i,ii,i0,j,jj, k;
552551
Int kk, kk1, kk2;
553552
// Entry a0, ai;
554-
double a0, ai;
555-
bv = (double) INF;
553+
Entry a0, ai;
554+
bv = (Entry) INF;
556555

557556
//Init used values
558557
i0 = -1;
@@ -562,15 +561,13 @@ namespace mwm_order
562561
iperm[k] = -1;
563562
jperm[k] = -1;
564563
pr[k] = col_ptr[k];
565-
//d[k] = (Entry) 0;
566-
d[k] = (double) 0;
564+
d[k] = (Entry) 0;
567565
}
568566

569567
//Scan over column nodes
570568
for(j=0; j<n; j++)
571569
{
572-
//a0 = (Entry) -1.0;
573-
a0 = (double) -1.0;
570+
a0 = (Entry) -1.0;
574571
//For each column node,
575572
for(k=col_ptr[j]; k<col_ptr[j+1]; k++)
576573
{
@@ -606,7 +603,7 @@ namespace mwm_order
606603
i0 = i;
607604
}
608605
}//for-k, row nodes
609-
if((a0 != ((double)(-1.0))) && (a0 < bv))
606+
if((a0 != ((Entry)(-1.0))) && (a0 < bv))
610607
{
611608
bv = a0;
612609
if(iperm[i0] != -1)
@@ -707,21 +704,18 @@ namespace mwm_order
707704
template<class Int, class Entry>
708705
int mwm_bn
709706
(
710-
Int n,
707+
Int n,
711708
Int nnz,
712-
Int *col_ptr,
709+
Int *col_ptr,
713710
Int *row_idx,
714711
Entry *val,
715-
Int *pr,
712+
Int *pr,
716713
Int *L,
717-
//Entry *d,
718-
double *d,
719-
Int *iperm,
720-
Int *jperm,
721-
//Int &num,
722-
//Entry &bv,
723-
Int &num,
724-
double &bv
714+
Entry *d,
715+
Int *iperm,
716+
Int *jperm,
717+
Int &num,
718+
Entry &bv
725719
)
726720
{
727721
Int i, i0;
@@ -730,19 +724,15 @@ namespace mwm_order
730724
Int jord, jdum, idum;
731725
Int qlen, low, up;
732726
Int q0;
733-
double dq0;
734-
//Entry dq0;
727+
Entry dq0;
735728

736-
double dnew, di;
737-
double csp;
738-
//Entry dnew, di;
739-
//Entry csp;
729+
Entry dnew, di;
730+
Entry csp;
740731
Int isp, jsp;
741732

742733
Int lpos;
743734

744-
//Entry MINONE = (Entry) -1.0;
745-
double MINONE = (double) -1.0;
735+
Entry MINONE = (Entry) -1.0;
746736

747737
Int *Q = new Int[n+1];
748738

@@ -1045,14 +1035,13 @@ namespace mwm_order
10451035
Int &num
10461036
)
10471037
{
1048-
double *d = new double[n];
1038+
Entry *d = new Entry[n];
10491039
Int *jperm = new Int[n];
10501040
Int *iperm = new Int[n];
10511041
Int *L = new Int[n];
10521042
Int *pr = new Int[n];
10531043

1054-
//Entry bv = 0;
1055-
double bv = 0;
1044+
Entry bv = 0;
10561045

10571046
mwm_bn_init(n,nnz,
10581047
col_ptr, row_idx, val,

packages/shylu/shylu_node/basker/src/shylubasker_order_scotch.hpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,8 @@ namespace BaskerNS
236236
// id of the first leaf node (BF order, post_order maps from BF to ND)
237237
Int leaves_id = pow(2.0, (double)(num_levels)) - 1;
238238
if (Options.verbose == BASKER_TRUE) {
239-
printf( " num_domains = %d: num_levels = %d, num_doms = %d, leves_id = %d\n",num_domains,num_levels,num_doms,leaves_id );
239+
printf( " num_domains = %d: num_levels = %d, num_doms = %d, leves_id = %d\n",
240+
int(num_domains),int(num_levels),int(num_doms),int(leaves_id) );
240241
}
241242

242243
// > insert root

packages/shylu/shylu_node/basker/test/amesos2_interface_test.cpp

+4-6
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,9 @@ int main(int argc, char* argv[])
129129
std::cout << "Done with Factor, Time: "
130130
<< totalTime(ftime, myTime()) << std::endl;
131131
//mybasker.DEBUG_PRINT();
132-
double ttime = myTime();
133132

134133
if (nontranspose) {
134+
double ttime = myTime();
135135
std::cout << "\n\n** Begin Solve **\n" << std::endl;
136136
mybasker.Solve(y,x);
137137
std::cout << "Done with Solve, Time: "
@@ -178,7 +178,7 @@ int main(int argc, char* argv[])
178178
x[i] = (Entry) 0.0;
179179
}
180180

181-
ttime = myTime();
181+
double ttime = myTime();
182182
std::cout << "\n\n** Begin Transpose Solve **\n" << std::endl;
183183
// transpose
184184
mybasker.Solve(yt,x,true);
@@ -216,17 +216,15 @@ int main(int argc, char* argv[])
216216
//---Options
217217
mybaskertr.SetThreads(nthreads);
218218
std::cout << "Setting Threads:" << nthreads << std::endl;
219-
double stime = myTime();
219+
stime = myTime();
220220
mybaskertr.Symbolic(m,n,nnz,col_ptr,row_idx,val);
221221
std::cout << "Done with Symbolic, Time: "
222222
<< totalTime(stime, myTime()) << std::endl;
223-
double ftime = myTime();
223+
ftime = myTime();
224224
mybaskertr.Factor(m,n,nnz,col_ptr,row_idx,val);
225225
std::cout << "Done with Factor, Time: "
226226
<< totalTime(ftime, myTime()) << std::endl;
227227
//mybaskertr.DEBUG_PRINT();
228-
double ttime = myTime();
229-
230228

231229
// Transpose solve:
232230
// This solve only works with square matrices

0 commit comments

Comments
 (0)