Update DbContextBulkTransaction code style

Author: MatinGhanbari

EFCore.BulkExtensions.Core/DbContextBulkTransaction.cs

@@ -12,97 +12,110 @@ internal static class DbContextBulkTransaction
 {
     public static void Execute<T>(DbContext context, Type? type, IEnumerable<T> entities, OperationType operationType, BulkConfig? bulkConfig, Action<decimal>? progress) where T : class
     {
-        SqlAdaptersMapping.ProviderName = context.Database.ProviderName;
+        UpdateSqlAdaptersProps(context);
 
         type ??= typeof(T);
 
         using (ActivitySources.StartExecuteActivity(operationType, entities.Count()))
         {
-            if (entities.Count() == 0 && 
-                operationType != OperationType.InsertOrUpdateOrDelete && 
-                operationType != OperationType.Truncate && 
-                operationType != OperationType.SaveChanges &&
-                (bulkConfig == null || bulkConfig.CustomSourceTableName == null) &&
-                (bulkConfig == null || bulkConfig.DataReader == null))
-            {
-                return;
-            }
+            if (!IsValidTransaction(entities, operationType, bulkConfig)) return;
 
             if (operationType == OperationType.SaveChanges)
             {
                 DbContextBulkTransactionSaveChanges.SaveChanges(context, bulkConfig, progress);
                 return;
             }
-            else if (bulkConfig?.IncludeGraph == true)
+
+            if (bulkConfig?.IncludeGraph == true)
             {
                 DbContextBulkTransactionGraphUtil.ExecuteWithGraph(context, entities, operationType, bulkConfig, progress);
+                return;
             }
-            else
-            {
-                TableInfo tableInfo = TableInfo.CreateInstance(context, type, entities, operationType, bulkConfig);
 
-                if (operationType == OperationType.Insert && !tableInfo.BulkConfig.SetOutputIdentity && tableInfo.BulkConfig.CustomSourceTableName == null)
-                {
+            var tableInfo = TableInfo.CreateInstance(context, type, entities, operationType, bulkConfig);
+
+            switch (operationType)
+            {
+                case OperationType.Insert when tableInfo.BulkConfig is { SetOutputIdentity: false, CustomSourceTableName: null }:
                     SqlBulkOperation.Insert(context, type, entities, tableInfo, progress);
-                }
-                else if (operationType == OperationType.Read)
-                {
+                    break;
+
+                case OperationType.Read:
                     SqlBulkOperation.Read(context, type, entities, tableInfo, progress);
-                }
-                else if (operationType == OperationType.Truncate)
-                {
+                    break;
+
+                case OperationType.Truncate:
                     SqlBulkOperation.Truncate(context, tableInfo);
-                }
-                else
-                {
+                    break;
+
+                default:
                     SqlBulkOperation.Merge(context, type, entities, tableInfo, operationType, progress);
-                }
+                    break;
             }
         }
     }
 
     public static async Task ExecuteAsync<T>(DbContext context, Type? type, IEnumerable<T> entities, OperationType operationType, BulkConfig? bulkConfig, Action<decimal>? progress, CancellationToken cancellationToken = default) where T : class
     {
-        SqlAdaptersMapping.ProviderName = context.Database.ProviderName;
+        UpdateSqlAdaptersProps(context);
 
         type ??= typeof(T);
 
         using (ActivitySources.StartExecuteActivity(operationType, entities.Count()))
         {
-            if (entities.Count() == 0 && operationType != OperationType.InsertOrUpdateOrDelete && operationType != OperationType.Truncate && operationType != OperationType.SaveChanges)
-            {
-                return;
-            }
+            if (!IsValidTransaction(entities, operationType, bulkConfig)) return;
 
             if (operationType == OperationType.SaveChanges)
             {
                 await DbContextBulkTransactionSaveChanges.SaveChangesAsync(context, bulkConfig, progress, cancellationToken).ConfigureAwait(false);
+                return;
             }
-            else if(bulkConfig?.IncludeGraph == true)
+
+            if (bulkConfig?.IncludeGraph == true)
             {
                 await DbContextBulkTransactionGraphUtil.ExecuteWithGraphAsync(context, entities, operationType, bulkConfig, progress, cancellationToken).ConfigureAwait(false);
+                return;
             }
-            else
-            {
-                TableInfo tableInfo = TableInfo.CreateInstance(context, type, entities, operationType, bulkConfig);
 
-                if (operationType == OperationType.Insert && !tableInfo.BulkConfig.SetOutputIdentity)
-                {
+            var tableInfo = TableInfo.CreateInstance(context, type, entities, operationType, bulkConfig);
+
+            switch (operationType)
+            {
+                case OperationType.Insert when !tableInfo.BulkConfig.SetOutputIdentity:
                     await SqlBulkOperation.InsertAsync(context, type, entities, tableInfo, progress, cancellationToken).ConfigureAwait(false);
-                }
-                else if (operationType == OperationType.Read)
-                {
+                    break;
+
+                case OperationType.Read:
                     await SqlBulkOperation.ReadAsync(context, type, entities, tableInfo, progress, cancellationToken).ConfigureAwait(false);
-                }
-                else if (operationType == OperationType.Truncate)
-                {
+                    break;
+
+                case OperationType.Truncate:
                     await SqlBulkOperation.TruncateAsync(context, tableInfo, cancellationToken).ConfigureAwait(false);
-                }
-                else
-                {
+                    break;
+
+                default:
                     await SqlBulkOperation.MergeAsync(context, type, entities, tableInfo, operationType, progress, cancellationToken).ConfigureAwait(false);
-                }
+                    break;
             }
         }
     }
+
+    #region SqlAdapters Settings
+    private static void UpdateSqlAdaptersProps(DbContext context)
+    {
+        SqlAdaptersMapping.ProviderName = context.Database.ProviderName;
+    }
+    #endregion
+
+    #region Transaction Validators
+    private static bool IsValidTransaction<T>(IEnumerable<T> entities, OperationType operationType, BulkConfig? bulkConfig)
+    {
+        return entities.Any() ||
+               operationType == OperationType.Truncate ||
+               operationType == OperationType.SaveChanges ||
+               operationType == OperationType.InsertOrUpdateOrDelete ||
+               bulkConfig is { CustomSourceTableName: not null } ||
+               bulkConfig is { DataReader: not null };
+    }
+    #endregion
 }