Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction Prompt stays if object is killed #17

Open
philspaz opened this issue Feb 7, 2021 · 1 comment
Open

Interaction Prompt stays if object is killed #17

philspaz opened this issue Feb 7, 2021 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@philspaz
Copy link

philspaz commented Feb 7, 2021

If you kill a character that is able to be revived, the revive prompt doesn't go away. I think I've fixed it in GSAT_WaitInteractableTarget.cpp in the block of code starting at 221.

if (!ReturnHitResult.bBlockingHit)
{
// No valid, available Interactable Actor

	//ReturnHitResult.Location = TraceEnd;   <----------Remove
	if (TargetData.Num() > 0 /*&& (TargetData.Get(0)->GetHitResult()->Actor.Get()*/)  <------Change
	{
		// Previous trace had a valid Interactable Actor, now we don't have one
		// Broadcast last valid target
		LostInteractableTarget.Broadcast(TargetData);
		TargetData.Clear();       <-------Add
	}

	//TargetData = MakeTargetData(ReturnHitResult);   <------Remove
}

this was causing TargetData.Num() > 0 to always be true which was fine unless the actor in the data just up and disappeared. I'm assuming it's because the reference to the actor isn't valid anymore so it comes back as false when you need it to be true. Hope that helps and doesn't cause more issues... Sorry, I don't know how to do the whole pull request stuff, I'm not really a programmer.

Phil

@tranek
Copy link
Owner

tranek commented Feb 20, 2021

I don't really know a good way to test this one by myself without another person. The joys of multiplayer development.

This code isn't meant to be a production-ready example -- just one way to do an interaction system purely using abilities for the sake of doing it only with abilities.

I'll leave this bug report open but I have no intention of fixing it. Thanks for reporting!

@tranek tranek added bug Something isn't working wontfix This will not be worked on labels Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants