Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible unnecessary cast in PlayMontageAndWaitForEvent #109

Closed
tommygod3 opened this issue Mar 17, 2023 · 2 comments
Closed

Possible unnecessary cast in PlayMontageAndWaitForEvent #109

tommygod3 opened this issue Mar 17, 2023 · 2 comments

Comments

@tommygod3
Copy link

I can't seem to see any reason we have to cast the ASC to a UGDAbilitySystemComponent in this class? In which case this may be an unnecessary cast:

@tranek tranek closed this as completed in 2eb9541 Mar 19, 2023
@tranek
Copy link
Owner

tranek commented Mar 19, 2023

Thanks! It was probably copied over from Epic's ARPG sample project.

@tommygod3
Copy link
Author

No worries, thank you for the fix! I would have put in a PR myself but have been looking into another issue: #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants