-
Notifications
You must be signed in to change notification settings - Fork 763
fix(openai_agents): Fixed the completion issue #3147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe logic for setting span attributes in response handling was refactored to use granular, indexed keys per message and content part, instead of aggregating values into lists. Corresponding test assertions were updated to verify the new indexed attribute keys, replacing checks on plural, aggregated attributes. Additionally, the README was updated to include "OpenAI Agents" as a newly supported instrumentation framework. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 850fc89 in 1 minute and 46 seconds. Click for details.
- Reviewed
112
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/opentelemetry-instrumentation-openai-agents/tests/test_openai_agents.py:67
- Draft comment:
Test assertions have been updated to check for indexed attribute keys (e.g. '.0.content', '.0.role', '.0.type') instead of aggregated lists. Ensure that this new naming convention is compatible with downstream consumers. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to ensure compatibility with downstream consumers, which violates the rule against asking the author to ensure behavior is intended or tested. It doesn't provide a specific suggestion or ask for a specific test to be written.
Workflow ID: wflow_sU5NgRTMfTvpe4e3
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
...emetry-instrumentation-openai-agents/opentelemetry/instrumentation/openai_agents/__init__.py
Outdated
Show resolved
Hide resolved
1097ce7
to
8aaec30
Compare
BEFORE

AFTER

feat(instrumentation): ...
orfix(instrumentation): ...
.Important
Fixes attribute setting for output messages in
set_response_content_span_attribute()
and updates tests accordingly.set_response_content_span_attribute()
in__init__.py
to handle each output message individually.test_agent_spans()
intest_openai_agents.py
to check for individual message attributes.test_agent_spans()
to verify new attribute structure.This description was created by
for 850fc89. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
Refactor
Tests
Documentation