Skip to content

Commit df1f216

Browse files
committed
feat: added ai workflow id to default reviewer
1 parent 67d72d4 commit df1f216

File tree

4 files changed

+25
-14
lines changed

4 files changed

+25
-14
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
/*
2+
Warnings:
3+
4+
- You are about to drop the column `isAIReviewer` on the `DefaultChallengeReviewer` table. All the data in the column will be lost.
5+
6+
*/
7+
-- AlterTable
8+
ALTER TABLE "DefaultChallengeReviewer" DROP COLUMN "isAIReviewer",
9+
ADD COLUMN "aiWorkflowId" VARCHAR(14);

prisma/schema.prisma

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -645,7 +645,7 @@ model DefaultChallengeReviewer {
645645
baseCoefficient Float?
646646
incrementalCoefficient Float?
647647
opportunityType ReviewOpportunityTypeEnum?
648-
isAIReviewer Boolean
648+
aiWorkflowId String? @db.VarChar(14)
649649
shouldOpenOpportunity Boolean @default(true)
650650
651651
// Relations

src/services/ChallengeService.js

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,6 @@ async function getDefaultReviewers(currentUser, criteria) {
280280
incrementalCoefficient: r.incrementalCoefficient,
281281
type: r.opportunityType,
282282
aiWorkflowId: r.aiWorkflowId,
283-
isAIReviewer: r.isAIReviewer,
284283
shouldOpenOpportunity: _.isBoolean(r.shouldOpenOpportunity) ? r.shouldOpenOpportunity : true,
285284
}));
286285
}
@@ -302,7 +301,6 @@ async function setDefaultReviewers(currentUser, data) {
302301
Joi.object().keys({
303302
scorecardId: Joi.string().required(),
304303
isMemberReview: Joi.boolean().required(),
305-
isAIReviewer: Joi.boolean().default(false),
306304
shouldOpenOpportunity: Joi.boolean().default(true),
307305
memberReviewerCount: Joi.when("isMemberReview", {
308306
is: true,
@@ -383,7 +381,7 @@ async function setDefaultReviewers(currentUser, data) {
383381
timelineTemplateId: _.isNil(value.timelineTemplateId) ? null : value.timelineTemplateId,
384382
scorecardId: String(r.scorecardId),
385383
isMemberReview: !!r.isMemberReview,
386-
isAIReviewer: !!r.isAIReviewer,
384+
aiWorkflowId:_.isNil(r.aiWorkflowId) ? null : r.aiWorkflowId,
387385
memberReviewerCount: _.isNil(r.memberReviewerCount)
388386
? null
389387
: Number(r.memberReviewerCount),
@@ -394,7 +392,6 @@ async function setDefaultReviewers(currentUser, data) {
394392
? null
395393
: Number(r.incrementalCoefficient),
396394
opportunityType: r.type ? _.toUpper(r.type) : null,
397-
aiWorkflowId: r.aiWorkflowId,
398395
shouldOpenOpportunity: _.isNil(r.shouldOpenOpportunity)
399396
? true
400397
: !!r.shouldOpenOpportunity,
@@ -1492,7 +1489,6 @@ async function createChallenge(currentUser, challenge, userToken) {
14921489
incrementalCoefficient: r.incrementalCoefficient,
14931490
type: r.opportunityType,
14941491
aiWorkflowId: r.aiWorkflowId,
1495-
isAIReviewer: r.isAIReviewer ?? false,
14961492
shouldOpenOpportunity: _.isBoolean(r.shouldOpenOpportunity)
14971493
? r.shouldOpenOpportunity
14981494
: true,
@@ -1660,7 +1656,6 @@ createChallenge.schema = {
16601656
Joi.object().keys({
16611657
scorecardId: Joi.string().required(),
16621658
isMemberReview: Joi.boolean().required(),
1663-
isAIReviewer: Joi.boolean().default(false),
16641659
shouldOpenOpportunity: Joi.boolean().default(true),
16651660
memberReviewerCount: Joi.when("isMemberReview", {
16661661
is: true,
@@ -2855,7 +2850,6 @@ updateChallenge.schema = {
28552850
Joi.object().keys({
28562851
scorecardId: Joi.string().required(),
28572852
isMemberReview: Joi.boolean().required(),
2858-
isAIReviewer: Joi.boolean().default(false),
28592853
shouldOpenOpportunity: Joi.boolean().default(true),
28602854
memberReviewerCount: Joi.when("isMemberReview", {
28612855
is: true,
@@ -3335,7 +3329,6 @@ function sanitizeChallenge(challenge) {
33353329
_.pick(rv, [
33363330
"scorecardId",
33373331
"isMemberReview",
3338-
"isAIReviewer",
33393332
"memberReviewerCount",
33403333
"phaseId",
33413334
"fixedAmount",

src/services/DefaultChallengeReviewerService.js

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -262,8 +262,9 @@ function normalizePayload(data = {}, isPartial = false) {
262262
} else if (!isPartial && _.isNil(data.opportunityType)) {
263263
normalized.opportunityType = null;
264264
}
265-
if (shouldAssign(data.isAIReviewer)) {
266-
normalized.isAIReviewer = data.isAIReviewer;
265+
266+
if (shouldAssign(data.aiWorkflowId)) {
267+
normalized.aiWorkflowId = data.aiWorkflowId;
267268
}
268269
if (shouldAssign(data.shouldOpenOpportunity)) {
269270
normalized.shouldOpenOpportunity = data.shouldOpenOpportunity;
@@ -338,7 +339,11 @@ createDefaultChallengeReviewer.schema = {
338339
baseCoefficient: Joi.number().min(0).max(1).allow(null),
339340
incrementalCoefficient: Joi.number().min(0).max(1).allow(null),
340341
opportunityType: Joi.string().valid(..._.values(ReviewOpportunityTypeEnum)).insensitive(),
341-
isAIReviewer: Joi.boolean().required(),
342+
aiWorkflowId: Joi.when("isMemberReview", {
343+
is: false,
344+
then: Joi.string().required(),
345+
otherwise: Joi.valid(null),
346+
}),
342347
shouldOpenOpportunity: Joi.boolean().required(),
343348
})
344349
.required(),
@@ -417,7 +422,11 @@ fullyUpdateDefaultChallengeReviewer.schema = {
417422
baseCoefficient: Joi.number().min(0).max(1).allow(null),
418423
incrementalCoefficient: Joi.number().min(0).max(1).allow(null),
419424
opportunityType: Joi.string().valid(..._.values(ReviewOpportunityTypeEnum)).insensitive(),
420-
isAIReviewer: Joi.boolean().required(),
425+
aiWorkflowId: Joi.when("isMemberReview", {
426+
is: false,
427+
then: Joi.string().required(),
428+
otherwise: Joi.valid(null),
429+
}),
421430
shouldOpenOpportunity: Joi.boolean().required(),
422431
})
423432
.required(),
@@ -516,7 +525,7 @@ partiallyUpdateDefaultChallengeReviewer.schema = {
516525
.valid(..._.values(ReviewOpportunityTypeEnum))
517526
.insensitive()
518527
.allow(null),
519-
isAIReviewer: Joi.boolean(),
528+
aiWorkflowId: Joi.string(),
520529
shouldOpenOpportunity: Joi.boolean(),
521530
})
522531
.required(),

0 commit comments

Comments
 (0)