Skip to content

Commit 4da44f4

Browse files
committed
Additional performance tweak
1 parent c57383e commit 4da44f4

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/services/ChallengeService.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -959,8 +959,12 @@ async function searchChallenges(currentUser, criteria) {
959959

960960
// FIXME: Tech Debt
961961
let excludeTasks = true;
962-
// if you're an admin or m2m, security rules wont be applied
963-
if (currentUser && (_hasAdminRole || _.get(currentUser, "isMachine", false))) {
962+
if (!_.isNil(criteria.memberId)) {
963+
// When we already restrict the result set to a specific member,
964+
// rerunning the generic task visibility filter is redundant.
965+
excludeTasks = false;
966+
} else if (currentUser && (_hasAdminRole || _.get(currentUser, "isMachine", false))) {
967+
// if you're an admin or m2m, security rules wont be applied
964968
excludeTasks = false;
965969
}
966970

0 commit comments

Comments
 (0)