From efbfa9efdb323c6e6fbbc1a39798b3db6cbbff6d Mon Sep 17 00:00:00 2001
From: Tiernan DeFranco <126631791+TiernanDeFranco@users.noreply.github.com>
Date: Sun, 9 Feb 2025 00:00:12 -0500
Subject: [PATCH] Simplified set_player_lamp in joycon.py

Instead of requiring the integer represenation of the binary number corresponding to the player lamp (1 is 1, 2 is 3, 3 is 7, 4 is 15 etc...), added a conversion so that you can pass in 1-8 for the player lamp and it will properly convert to 1 3 7 15 9 10 11 6 respectively for players 1-8
---
 pyjoycon/joycon.py | 31 +++++++++++++++++++++++++++----
 1 file changed, 27 insertions(+), 4 deletions(-)

diff --git a/pyjoycon/joycon.py b/pyjoycon/joycon.py
index 4e6fdee..7568a1d 100644
--- a/pyjoycon/joycon.py
+++ b/pyjoycon/joycon.py
@@ -424,10 +424,33 @@ def set_player_lamp_flashing(self, flashing_pattern: int):
             b'\x01', b'\x30',
             ((flashing_pattern & 0xF) << 4).to_bytes(1, byteorder='little'))
 
-    def set_player_lamp(self, pattern: int):
-        self._write_output_report(
-            b'\x01', b'\x30',
-            pattern.to_bytes(1, byteorder='little'))
+     def set_player_lamp(self, player_number: int):
+            binaryPattern = 1
+            # Determine the binary based on the input number
+            if player_number == 1:
+                binaryPattern = 1    # 0001
+            elif player_number == 2:
+                binaryPattern = 3    # 0011
+            elif player_number == 3:
+                binaryPattern = 7    # 0111
+            elif player_number == 4:
+                binaryPattern = 15   # 1111
+            elif player_number == 5:
+                binaryPattern = 9    # 1001
+            elif player_number == 6:
+                binaryPattern = 10   # 1010
+            elif player_number == 7:
+                binaryPattern = 11   # 1011  
+            elif player_number == 8:
+                binaryPattern = 6    # 0110
+            else:
+                raise ValueError("Invalid player number. Must be between 1 and 8.")
+    
+            # Write the output report with the determined byte pattern
+            self._write_output_report(
+                b'\x01', b'\x30',
+                binaryPattern.to_bytes(1, byteorder='little')
+            )
 
     def disconnect_device(self):
         self._write_output_report(b'\x01', b'\x06', b'\x00')