Skip to content

Commit 51fb507

Browse files
committed
Only add the pagination query params when the endpoint can be paginated
1 parent 6d301e8 commit 51fb507

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

src/Endpoint/Concerns/BuildsOpenApiPaths.php

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,13 @@ private function buildOpenApiContent(array $resources, bool $multiple = false, b
2929

3030
private function buildOpenApiParameters(Resource $resource): array
3131
{
32-
return [
33-
...$this->buildIncludeParameter($resource),
34-
...$this->buildPaginationParameters($resource),
35-
];
32+
$parameters = [$this->buildIncludeParameter($resource)];
33+
34+
if (property_exists($this, 'paginationResolver')) {
35+
$parameters = array_merge_recursive($parameters, $this->buildPaginatableParameters());
36+
}
37+
38+
return $parameters;
3639
}
3740

3841
private function buildIncludeParameter(Resource $resource): array
@@ -52,18 +55,16 @@ private function buildIncludeParameter(Resource $resource): array
5255
$includes = implode(', ', $relationshipNames);
5356

5457
return [
55-
[
56-
'name' => 'include',
57-
'in' => 'query',
58-
'description' => "Available include parameters: {$includes}.",
59-
'schema' => [
60-
'type' => 'string',
61-
],
58+
'name' => 'include',
59+
'in' => 'query',
60+
'description' => "Available include parameters: {$includes}.",
61+
'schema' => [
62+
'type' => 'string',
6263
],
6364
];
6465
}
6566

66-
private function buildPaginationParameters(Resource $resource): array
67+
private function buildPaginatableParameters(): array
6768
{
6869
return [
6970
[

0 commit comments

Comments
 (0)