Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle main branch build errors #77

Open
tobie opened this issue Jun 29, 2020 · 0 comments
Open

Handle main branch build errors #77

tobie opened this issue Jun 29, 2020 · 0 comments

Comments

@tobie
Copy link
Owner

tobie commented Jun 29, 2020

In order to build an HTML diff, PR Preview must be able to successfully build the main branch.

If the main branch can't be built, that throws an error, regardless of whether or not the branch build itself can be fixed.

This is confusing to users and must be corrected.

Plan:

If building the branch itself doesn't fail, build and display that. Add an error message explaining why the diff cannot be shown, and/or attempt at forcing a build of the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant