-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bikeshed include files. #27
Comments
Fixes tobie#27. This depends on a to-be-added extension to http://hg.csswg.org/dev/bikeshed-web/ to accept an include_urls[] query parameter.
I'm doing this in 3 parts:
|
Note that now that we’ve collected the array of urls for the includes, we can also pass them as part of the query parameters if that’s easier to implement in bikeshed. |
It was easier for Bikeshed to just look things up relative to the input URL. @frivoal, your use case is going to require you to list the custom boilerplate files in the Local Boilerplate metadata. |
Thanks everyone (@tobie, @plinss, @tabatkins, @marcoscaceres, @sidvishnoi) for the design help and reviews! |
This is so awesome! Congrats!! |
https://api.csswg.org/bikeshed/ and https://github.com/tobie/pr-preview/ are a great combo, except that in addition to my index.bs file, I have local custom *.include files, and if these don't stay together with the spec, the result isn't the intended one.
(cc @plinss) https://api.csswg.org/bikeshed/ should be patched to allow uploading multiple files so that I can do something like:
Then https://github.com/tobie/pr-preview/ should be updated to support that.
The text was updated successfully, but these errors were encountered: