Skip to content

Django 4.2 Support #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jseadragon opened this issue Jul 6, 2023 · 2 comments
Open

Django 4.2 Support #136

jseadragon opened this issue Jul 6, 2023 · 2 comments

Comments

@jseadragon
Copy link

Recently I tried to use it with Django 4.2 (current LTS) and ran into this error:

  File "/Users/username/.venvs/work/lib/python3.11/site-packages/restless/dj.py", line 4, in <module>
    from django.conf.urls import url
ImportError: cannot import name 'url' from 'django.conf.urls' (/Users/username/.venvs/work/lib/python3.11/site-packages/django/conf/urls/__init__.py)

See: https://docs.djangoproject.com/en/dev/internals/deprecation/#deprecation-removed-in-4-0

  • django.conf.urls.url() will be removed.

It seems the url function was deprecated in Django 3.x and is no longer supported in 4.x. Thus, we will have to update this. https://stackoverflow.com/a/70319607

However, it seems this library is not maintained (Re: #135), so even if I submitted a PR I am not sure it would do anyone any good. Hence, opening this issue for others to stumble upon when they inevitably upgrade.

@jseadragon
Copy link
Author

jseadragon commented Jul 6, 2023

It seems this fix has already been done. Twice, in fact. It seems a lot of folks are starting to use newer Django.

@toastdriven do you still maintain this library? Is there anyone who can help get this fix out? I think #129 is cleaner and will probably take the least time to review since there are some small refactoring changes in #134

@jseadragon
Copy link
Author

@seocam you have merged some PRs to this repo in the past, is this something you can help with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant