-
Notifications
You must be signed in to change notification settings - Fork 135
Set the current game mode to whatever a save file was made in when loading. #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Is this worth adding to the log in |
tmewett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks, looks like the most sensible solution
There's a slight variation that's possible where we just set the mode to whatever the file says, and don't error out, if you were interested.
My only feedback is one question
we usually want every user-facing change, so yes please |
8edad12 to
4fe662a
Compare
Actually now you say this I think I will change the solution. |
This will be useful when we check that a save was made in the same mode as the one the game is in.
4fe662a to
3fb2833
Compare
|
OK, I've moved to the mode-changing solution instead, and based on |
Closes #747 .
Does so by squashing wizard mode and easy mode into an enumeration that is stored in the save file, and checking that this flag matches the current mode.
This will break save files, so this branch as based on
master.