Skip to content

Conversation

@ZayadNimrod
Copy link

Closes #747 .

Does so by squashing wizard mode and easy mode into an enumeration that is stored in the save file, and checking that this flag matches the current mode.

This will break save files, so this branch as based on master.

@ZayadNimrod
Copy link
Author

Is this worth adding to the log in changes/?

Copy link
Owner

@tmewett tmewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks, looks like the most sensible solution

There's a slight variation that's possible where we just set the mode to whatever the file says, and don't error out, if you were interested.

My only feedback is one question

@tmewett
Copy link
Owner

tmewett commented Dec 1, 2025

Is this worth adding to the log in changes/?

we usually want every user-facing change, so yes please

@ZayadNimrod ZayadNimrod force-pushed the issue-747 branch 2 times, most recently from 8edad12 to 4fe662a Compare December 1, 2025 22:28
@ZayadNimrod
Copy link
Author

ZayadNimrod commented Dec 1, 2025

There's a slight variation that's possible where we just set the mode to whatever the file says, and don't error out, if you were interested.

Actually now you say this I think I will change the solution.

@ZayadNimrod
Copy link
Author

OK, I've moved to the mode-changing solution instead, and based on release instead, since this shouldn't break anything from the user's perspective.

@ZayadNimrod ZayadNimrod changed the title Refuse to load files made in Easy mode if not in Easy mode and vice versa Set the current game mode to whatever a save file was made in when loading. Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Easy mode not part of save file

4 participants