-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper README with summary of usage, etc. #4
Comments
I just added a README, feel free to close this if it seems complete enough to you 🙂 |
Part of tmattio#4.
One last request besides the PR. The CI badge in the README is red, and looking at the history, all CI runs have failed. Is the CI easily fixable? If not, would you consider removing the badge? |
Part of tmattio#4.
The CI is fixed now! For the record, one of the failure was due to the Windows pipeline, which was failing because |
Dream does intend to support Windows (and more or less already should), but the best way to support Windows will be when Lwt is switched to use libuv through Luv (or we switch to multicore and multicore supports Windows). |
I'm closing the issue since the README parts are solved, thanks :) |
Maybe I misinterpreted the CI error: https://github.com/tmattio/dream-livereload/runs/2970137498?check_suite_focus=true The error is:
|
Perhaps I got the syntax of the I'm concerned about the Bisect_ppx messages. Bisect_ppx doesn't actually constraint Dream from installing on 4.12. Is this due to ocamlformat? Is there a stale cache in CI? |
No rush! Just noting it for now.
The text was updated successfully, but these errors were encountered: