Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement list #24

Open
2 of 5 tasks
gshipunov opened this issue Mar 29, 2023 · 0 comments
Open
2 of 5 tasks

Improvement list #24

gshipunov opened this issue Mar 29, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@gshipunov
Copy link
Member

gshipunov commented Mar 29, 2023

Some minor problems I came across while reviewing #23

  • all the config env vars need to be prepended with DATACARE_, so there's no conflicts if services are run in the same environ
  • If prometheus endpoint fails, datacare panics. Maybe worth just log it and forget about it.
  • CORS just allows everything at the moment
  • #![deny(missing_docs)]
  • #![warn(rustdoc::broken_intra_doc_links)]

I guess this can be left alone for now, but we need to get back to it after the feature freeze. If you see any other rough edges, plz append to the list above

@gshipunov gshipunov added the enhancement New feature or request label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants