From 77d98a77441e55e1ec5b98d67d7632a83991c442 Mon Sep 17 00:00:00 2001 From: Patrick Cason Date: Mon, 4 Apr 2016 14:34:35 -0500 Subject: [PATCH 1/2] Added orientation --- demo/index.js | 1 + src/NumberEditor.js | 11 +++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/demo/index.js b/demo/index.js index bbce59a..4fe009a 100644 --- a/demo/index.js +++ b/demo/index.js @@ -35,6 +35,7 @@ class Demo extends React.Component { max={10000} min={-10} decimals={2} + orientation="horizontal" onValueChange={this._onNumberChange} step={0.1} value={this.state.numberValue} diff --git a/src/NumberEditor.js b/src/NumberEditor.js index 0caa904..513dfec 100644 --- a/src/NumberEditor.js +++ b/src/NumberEditor.js @@ -32,6 +32,7 @@ class NumberEditor extends React.Component { decimals: PropTypes.number, max: PropTypes.number, min: PropTypes.number, + orientation: PropTypes.string, onValueChange: PropTypes.func, step: PropTypes.number, stepModifier: PropTypes.number, @@ -48,6 +49,7 @@ class NumberEditor extends React.Component { decimals: 0, max: Number.MAX_VALUE, min: -Number.MAX_VALUE, + orientation: 'horizontal', onValueChange: () => { // do nothing }, @@ -81,7 +83,12 @@ class NumberEditor extends React.Component { if(nextProps.dataDrag.isMoving) { const step = this._getStepValue(nextProps.dataDrag, this.props.step); - this._changeValue(this.state.dragStartValue + nextProps.dataDrag.moveDeltaX * (step / 2)); + if(this.props.orientation === 'horizontal') { + this._changeValue(this.state.dragStartValue + nextProps.dataDrag.moveDeltaX * (step / 2)); + } + else { + this._changeValue(this.state.dragStartValue + nextProps.dataDrag.moveDeltaY * (step / 2)); + } } } @@ -163,7 +170,7 @@ class NumberEditor extends React.Component { } render() { - let cursor = 'ew-resize'; + let cursor = this.props.orientation === 'horizontal' ? 'ew-resize' : 'ns-resize'; let readOnly = true; let value = this.props.value; if(this.state.startEditing) { From 47c6a4582a1bd847ead2ca81d2fbc2f01a804be6 Mon Sep 17 00:00:00 2001 From: Patrick Cason Date: Mon, 4 Apr 2016 16:42:27 -0500 Subject: [PATCH 2/2] More explicit --- src/NumberEditor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/NumberEditor.js b/src/NumberEditor.js index 513dfec..d7da14c 100644 --- a/src/NumberEditor.js +++ b/src/NumberEditor.js @@ -86,7 +86,7 @@ class NumberEditor extends React.Component { if(this.props.orientation === 'horizontal') { this._changeValue(this.state.dragStartValue + nextProps.dataDrag.moveDeltaX * (step / 2)); } - else { + else if(this.props.orientation === 'vertical') { this._changeValue(this.state.dragStartValue + nextProps.dataDrag.moveDeltaY * (step / 2)); } }