update clb binding status if pool or lb is deleted

Signed-off-by: roc <[email protected]>

Author: imroc

internal/controller/clbbinding.go

@@ -82,6 +82,10 @@ func (r *CLBBindingReconciler[T]) sync(ctx context.Context, bd T) (result ctrl.R
 }
 
 func (r *CLBBindingReconciler[T]) ensureCLBBinding(ctx context.Context, bd clbbinding.CLBBinding) error {
+	// 确保依赖的端口池和 CLB 都存在，如果已删除则释放端口并更新状态
+	if err := r.ensurePoolAndCLB(ctx, bd); err != nil {
+		return err
+	}
 	// 确保所有端口都被分配
 	if err := r.ensurePortAllocated(ctx, bd); err != nil {
 		return errors.WithStack(err)
@@ -97,6 +101,34 @@ func (r *CLBBindingReconciler[T]) ensureCLBBinding(ctx context.Context, bd clbbi
 	return nil
 }
 
+func (r *CLBBindingReconciler[T]) ensurePoolAndCLB(ctx context.Context, bd clbbinding.CLBBinding) error {
+	status := bd.GetStatus()
+	newBindings := []networkingv1alpha1.PortBindingStatus{}
+	needUpdateStatus := false
+	for i := range status.PortBindings {
+		binding := &status.PortBindings[i]
+		pool := portpool.Allocator.GetPool(binding.Pool)
+		if pool == nil { // 端口池不存在，将端口绑定状态置为 Failed，并记录事件
+			r.Recorder.Event(bd.GetObject(), corev1.EventTypeWarning, "PortPoolDeleted", fmt.Sprintf("port pool has been deleted (%s/%s/%d)", binding.Pool, binding.LoadbalancerId, binding.LoadbalancerPort))
+			needUpdateStatus = true
+		} else {
+			if !pool.IsLbExists(binding.LoadbalancerId) {
+				r.Recorder.Event(bd.GetObject(), corev1.EventTypeWarning, "CLBDeleted", fmt.Sprintf("clb has been deleted (%s/%s/%d)", binding.Pool, binding.LoadbalancerId, binding.LoadbalancerPort))
+				needUpdateStatus = true
+			} else {
+				newBindings = append(newBindings, *binding)
+			}
+		}
+	}
+	if needUpdateStatus {
+		status.PortBindings = newBindings
+		if err := r.Status().Update(ctx, bd.GetObject()); err != nil {
+			return errors.WithStack(err)
+		}
+	}
+	return nil
+}
+
 func (r *CLBBindingReconciler[T]) ensureListeners(ctx context.Context, bd clbbinding.CLBBinding) error {
 	log.FromContext(ctx).V(10).Info("ensureListeners")
 	status := bd.GetStatus()

internal/portpool/portpool.go

@@ -101,10 +101,15 @@ func (pp *PortPool) AllocatePort(ctx context.Context, ports ...ProtocolPort) ([]
 	return nil, nil
 }
 
+// 释放已分配的端口
 func (pp *PortPool) ReleasePort(lbId string, port ProtocolPort) {
 	pp.mu.Lock()
 	defer pp.mu.Unlock()
-	delete(pp.cache[lbId], port)
+	cache := pp.cache[lbId]
+	if cache == nil {
+		return
+	}
+	delete(cache, port)
 }
 
 func (pp *PortPool) EnsureLbIds(lbIds []string) {
@@ -132,3 +137,10 @@ func (pp *PortPool) EnsureLbIds(lbIds []string) {
 		pp.cache[lbId] = make(map[ProtocolPort]struct{})
 	}
 }
+
+func (pp *PortPool) IsLbExists(lbId string) bool {
+	pp.mu.Lock()
+	_, exists := pp.cache[lbId]
+	defer pp.mu.Unlock()
+	return exists
+}

internal/portpool/util/portpool.go

@@ -56,3 +56,14 @@ func NewPortPool(pp *networkingv1alpha1.CLBPortPool, c client.Client) *PortPool
 		Client:      c,
 	}
 }
+
+// func ProtocolPortFromBindingStatus(binding *networkingv1alpha1.PortBindingStatus) portpool.ProtocolPort {
+// 	pp := ProtocolPort{
+// 		Port:     binding.Port,
+// 		Protocol: binding.Protocol,
+// 	}
+// 	if binding.LoadbalancerEndPort != nil {
+// 		pp.EndPort = *binding.LoadbalancerEndPort
+// 	}
+// 	return pp
+// }