Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Empty rect with an offset shouldn't be loaded #333

Closed
sapierens opened this issue Apr 8, 2018 · 1 comment
Closed

Bug: Empty rect with an offset shouldn't be loaded #333

sapierens opened this issue Apr 8, 2018 · 1 comment
Assignees
@sapierens
Labels
bug

Comments

@sapierens
Copy link
Collaborator

Currently, as mentioned in #327 - if a rect that's returned for an image element is empty, the image will still be loaded if offset is greater than 0. That should not be happening since the image element at the time of checking virtually does not exist.

A simple check for an empty rect should be enough, I'll try to get out a PR in the coming days.
@sapierens sapierens self-assigned this Apr 8, 2018
@sapierens sapierens added the bug label Apr 8, 2018
@tjoskar
Copy link
Owner

tjoskar commented Apr 8, 2018

I agree, this is a bug.

@sapierens sapierens mentioned this issue Apr 27, 2018
Merged
tjoskar pushed a commit that referenced this issue May 19, 2018
Merge pull request #342 from sapierens/bugfix/empty-rect-detection
506d655 
Added rect/isVisible logic to return faster when element is invisible. #333
@tjoskar tjoskar closed this as completed May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sapierens sapierens

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tjoskar @sapierens