default values for "LDAP user mail field" and "LDAP username field" are not applied

[psuter80]

Describe the bug

in the configuration gui, when the "LDAP user mail field" and "LDAP username field" are not explicitly filled with a value, the extension won't work and a login attempt will fail with this error:

Argument 2 passed to Flarum\Forum\Auth\ResponseFactory::make() must be of the type string, null given

the reason for this is, that the GUI show a placeholder value of "mail" and "uid" in the input boxes but those values are not applied unless they are overwritten. So in a setup such as mine, where "mail" and "uid" are the correct parameters, i need to overwrite the placeholder with those values or the above error will appear.

on the other hand, the "port" field may be left empty (still showing the placeholder) and the connectionto the server will still work.

Expected behavior

if there is no data entered into the "user mail" and "username" field, the default value shold be applied, like the GUI suggests.

Versions

• Flarum version: v1.0.0-p6