Skip to content

Commit c37de57

Browse files
committed
Release 4.0.31 - See CHANGELOG.md
1 parent eeeafd6 commit c37de57

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## 4.0.31 2023-12-12 <dave at tiredofit dot ca>
2+
3+
### Changed
4+
- Support backing up databases with spaces in them
5+
6+
17
## 4.0.30 2023-12-11 <dave at tiredofit dot ca>
28

39
### Added

install/assets/functions/10-db-backup

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,11 @@ bootstrap_variables() {
153153
fi
154154
##
155155

156+
if grep -qo ".*_NAME='.*'" "${backup_instance_vars}"; then
157+
print_debug "[bootstrap_variables] [backup_init] Found _NAME variable with quotes"
158+
sed -i "s|_NAME='\(.*\)'|_NAME=\1|g" "${backup_instance_vars}"
159+
fi
160+
156161
if grep -qo ".*_PASS='.*'" "${backup_instance_vars}"; then
157162
print_debug "[bootstrap_variables] [backup_init] Found _PASS variable with quotes"
158163
sed -i "s|_PASS='\(.*\)'|_PASS=\1|g" "${backup_instance_vars}"
@@ -599,7 +604,7 @@ backup_mssql() {
599604
pre_dbbackup "${backup_job_db_name}"
600605
write_log notice "Dumping MSSQL database: '${backup_job_db_name}'"
601606
if var_true "${DEBUG_BACKUP_MSSQL}" ; then debug on; fi
602-
silent run_as_user ${play_fair} /opt/mssql-tools18/bin/sqlcmd -C -S ${backup_job_db_host}\,${backup_job_db_port} -U ${backup_job_db_user} -P ${backup_job_db_pass} -Q "BACKUP DATABASE ['${backup_job_db_name}'] TO DISK = N'${temporary_directory}/${backup_job_filename}' WITH NOFORMAT, NOINIT, NAME = '${backup_job_db_name}-full', SKIP, NOREWIND, NOUNLOAD, STATS = 10"
607+
silent run_as_user ${play_fair} /opt/mssql-tools18/bin/sqlcmd -C -S ${backup_job_db_host}\,${backup_job_db_port} -U ${backup_job_db_user} -P ${backup_job_db_pass} -Q "BACKUP DATABASE [${backup_job_db_name}] TO DISK = N'${temporary_directory}/${backup_job_filename}' WITH NOFORMAT, NOINIT, NAME = '${backup_job_db_name}-full', SKIP, NOREWIND, NOUNLOAD, STATS = 10"
603608
exit_code=$?
604609
if var_true "${DEBUG_BACKUP_MSSQL}" ; then debug off; fi
605610
backup_job_filename_original=${backup_job_filename}

0 commit comments

Comments
 (0)