adding angular array syntax for minification support #1
Conversation
|
+1 Good find |
| @@ -1,14 +1,14 @@ | |||
| 'use strict'; | |||
|
|
|||
| angular.module('ng.picturefill', []) | |||
| .directive('pictureFill', function () { | |||
| .directive('pictureFill', [function () { | |||
| return { | |||
| controller: 'PictureFillCtrl', | |||
| link: function (scope, elem, attrs) { | |||
There was a problem hiding this comment.
array syntax not needed for link functions. It's arguments are based on order not name
|
if you're using grunt to build you can just use the ng-min task and it will handle this for you. https://github.com/btford/grunt-ngmin |
|
Yes you can rely on that library. I thought there no harm in including it directly into the library to save the additional effort. Happy for you to reject the PR. Perhaps it is worth mentioning in the |
|
(i don't own this repository - just a polyfill for those in need) |
|
I had considered submitting this myself, thanks for doing so. While ngMin will do it for you, I like to be formed like this. |
adding angular array syntax for minification support
|
Thanks! |
Allows for error free minification